Skip to contentSkip to conversation

Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

PATCH In review Jesper Nilsson 2 participants 3 messages Dec 20, 2007 – Jan 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

This is very old code, it hasn't changed since 2001 and it is not used anywhere. Noticed by Clemens Koller.

---
 include/asm-cris/bitops.h |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
include/asm-cris/bitops.h +0 -7
index e2f49c2..75ea6e0 100644
@@ -24,13 +24,6 @@
 #include <linux/compiler.h>
 
 /*
- * Some hacks to defeat gcc over-optimizations..
- */
-struct __dummy { unsigned long a[100]; };
-#define ADDR (*(struct __dummy *) addr)
-#define CONST_ADDR (*(const struct __dummy *) addr)
-
-/*
  * set_bit - Atomically set a bit in memory
  * @nr: the bit to set
  * @addr: the address to start counting from
Signature · 5 lines
1.5.3.6.970.gd25430

/^JN - Jesper Nilsson
--
               Jesper Nilsson -- [email protected]
#1 lore raw
Quoted 1 line · On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <[email protected]>…

Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

It's nice (and conventional) to prefix the patch title with the subsystem name. So this one would become

Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h

Thanks.

#2 lore raw
Quoted 5 lines · Andrew Morton
Quoted 1 line · On Thu, 20 Dec 2007 11:09:44 +0100 Jesper Nilsson <[email protected]>…

Subject: [PATCH] Remove unused __dummy, CONST_ADDR and ADDR from CRIS bitops.h

It's nice (and conventional) to prefix the patch title with the subsystem name.

Sorry about that, will add that to my checklist.

Quoted 5 lines

So this one would become

Subject: [PATCH] cris: remove unused __dummy, CONST_ADDR and ADDR from bitops.h

Thanks.

No, thank you. :-)

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]