Skip to contentSkip to conversation

kvm: external module: Remove 'include/asm' before execute 'ln'

PATCH Applied Yang, Sheng 2 participants 2 messages Dec 20, 2007 1 message not in the archive KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: external module: Remove 'include/asm' before execute 'ln'

From 33d84813131809e962a4cd8cae9b66a9062fa8db Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Thu, 20 Dec 2007 14:22:18 +0800
Subject: [PATCH] kvm: external module: Remove 'include/asm' before execute 'ln'

We use 'ln -sf' to refresh the symbolic now. But if 'include/asm' is a directory (as in old layout), 'ln' will give wrong result.

---
 kernel/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/Makefile +2 -1
index d409a0a..e5d9fff 100644
@@ -35,7 +35,8 @@ sync:
 	     "$(LINUX)"/./include/linux/kvm*.h \
 	     "$(LINUX)"/./include/asm-x86/kvm*.h \
              tmp/
-	ln -sf asm-x86 include/asm
+	rm -rf include/asm
+	ln -s asm-x86 include/asm
 
 	$(call unifdef, include/linux/kvm.h)
 	$(call unifdef, include/linux/kvm_para.h)
Signature · 1 line
1.5.3.4

From 33d84813131809e962a4cd8cae9b66a9062fa8db Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Thu, 20 Dec 2007 14:22:18 +0800
Subject: [PATCH] kvm: external module: Remove 'include/asm' before execute 'ln'

We use 'ln -sf' to refresh the symbolic now. But if 'include/asm' is a directory (as in old layout), 'ln' will give wrong result.

---
 kernel/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/Makefile +2 -1
index d409a0a..e5d9fff 100644
@@ -35,7 +35,8 @@ sync:
 	     "$(LINUX)"/./include/linux/kvm*.h \
 	     "$(LINUX)"/./include/asm-x86/kvm*.h \
              tmp/
-	ln -sf asm-x86 include/asm
+	rm -rf include/asm
+	ln -s asm-x86 include/asm
 
 	$(call unifdef, include/linux/kvm.h)
 	$(call unifdef, include/linux/kvm_para.h)
Signature · 1 line
1.5.3.4

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

A message that is not in the archive (sent off-list or not yet received): 200712201424.52990.sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org

Applied
#2 lore raw
Quoted 10 lines · Sheng

From 33d84813131809e962a4cd8cae9b66a9062fa8db Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Thu, 20 Dec 2007 14:22:18 +0800
Subject: [PATCH] kvm: external module: Remove 'include/asm' before execute 'ln'

We use 'ln -sf' to refresh the symbolic now. But if 'include/asm' is a directory (as in old layout), 'ln' will give wrong result.

Applied, thanks. This has bitten several people already.

Signature · 9 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace