Skip to contentSkip to conversation

libkvm: fix mungled default case for switch in kvm_arch_run

PATCH Applied Carlo Marcelo Arenas Belon 2 participants 2 messages Dec 28, 2007 – Dec 30, 2007 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libkvm: fix mungled default case for switch in kvm_arch_run

This patch corrects 03f1b5e137e7e4c8dd51dbaea6779be853f4fde0, that modified the logic behind kvm_arch_run because of a mangled endif which accidentally included the default entry for the switch.

kvm_arch_run as defined in 4f19bdea03330641fd48514ea84d1ed1bf431507 was affected by returning 0 by default instead of 1 and reporting the following warning at compile time :

libkvm-x86.c:201:9: warning: extra tokens at end of #endif directive

---
 libkvm/libkvm-x86.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
libkvm/libkvm-x86.c +2 -1
index e6eb66e..2fa8146 100644
@@ -198,7 +198,8 @@ int kvm_arch_run(struct kvm_run *run,kvm_context_t kvm, int vcpu)
 		case KVM_EXIT_TPR_ACCESS:
 			r = handle_tpr_access(kvm, run, vcpu);
 			break;
-#endif		default:
+#endif
+		default:
 			r = 1;
 			break;
 	}
Signature · 7 lines
1.5.2.5


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Applied
#1 lore raw
Quoted 11 lines · Carlo Marcelo Arenas Belon

This patch corrects 03f1b5e137e7e4c8dd51dbaea6779be853f4fde0, that modified the logic behind kvm_arch_run because of a mangled endif which accidentally included the default entry for the switch.

kvm_arch_run as defined in 4f19bdea03330641fd48514ea84d1ed1bf431507 was affected by returning 0 by default instead of 1 and reporting the following warning at compile time :

libkvm-x86.c:201:9: warning: extra tokens at end of #endif directive

Applied, thanks.

Signature · 7 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/