the scheduled 'time' option removal

PATCH In review Adrian Bunk 3 participants 6 messages Jan 1, 2008 – Jan 20, 2008 Documentation

lore

Share & tools

lore

Adrian Bunk

author

2008-01-01 13:47 UTC #0 lore raw

PATCH 1/1 the scheduled 'time' option removal

This patch contains the scheduled removal of the 'time' option.

Signed-off-by Adrian Bunk <[email protected]>

---

 Documentation/feature-removal-schedule.txt |    8 --------
 kernel/printk.c                            |   13 -------------
 2 files changed, 21 deletions(-)

c0ea16c447460698c0e85963310c38fa051f0e23

Documentation/feature-removal-schedule.txt +0 -8

index 20c4c8b..93aac19 100644
@@ -233,10 +233,2 @@ Who:	Jean Delvare <[email protected]>
 ---------------------------
-
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-
----------------------------

kernel/printk.c +0 ~~-13~~

index a30fe33..296c4ea 100644
@@ -560,15 +560,2 @@ static int printk_time = 0;
 module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
-
-static int __init printk_time_setup(char *str)
-{
-	if (*str)
-		return 0;
-	printk_time = 1;
-	printk(KERN_NOTICE "The 'time' option is deprecated and "
-		"is scheduled for removal in early 2008\n");
-	printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n");
-	return 1;
-}
-
-__setup("time", printk_time_setup);

Jan Engelhardt

2008-01-01 17:54 UTC #1 lore raw

Documentation/feature-removal-schedule.txt Who: Jean Delvare <[email protected]> · line 240

Quoted 12 lines · Adrian Bunk

index 20c4c8b..93aac19 100644

Documentation/feature-removal-schedule.txt +0 -8

@@ -233,10 +233,2 @@ Who:	Jean Delvare <[email protected]>
---------------------------
-
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-

I am sure the people who added themselves in the Who: line would have taken care of this soon enough, I mean, it's just 19 hours into the first day :-)

Adrian Bunk

author

2008-01-01 23:57 UTC #2 lore raw

Quoted 18 lines · Jan Engelhardt

Documentation/feature-removal-schedule.txt Who: Jean Delvare <[email protected]> · line 240
Quoted 12 lines · Adrian Bunk
index 20c4c8b..93aac19 100644
Documentation/feature-removal-schedule.txt +0 -8
@@ -233,10 +233,2 @@ Who:	Jean Delvare <[email protected]>
---------------------------
-
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-
I am sure the people who added themselves in the Who: line would have taken care of this soon enough, I mean, it's just 19 hours into the first day :-)

If Randy decides he wants to submit his own patch for this that wouldn't be a problem for me. :-)

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Randy Dunlap

2008-01-02 02:09 UTC #3 lore raw

In reply to Adrian Bunk

Quoted 3 lines · On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote:

This patch contains the scheduled removal of the 'time' option.
Signed-off-by Adrian Bunk <[email protected]>

Thanks. Looks good except that Documentation/kernel-parameters.txt needs a patch also: delete these 3 lines:

time Show timing data prefixed to each printk message line
[deprecated, see 'printk.time']

then I will Ack it.

Quoted 31 lines

---

 Documentation/feature-removal-schedule.txt |    8 --------
 kernel/printk.c                            |   13 -------------
 2 files changed, 21 deletions(-)

c0ea16c447460698c0e85963310c38fa051f0e23

Documentation/feature-removal-schedule.txt +0 -8

index 20c4c8b..93aac19 100644
@@ -233,10 +233,2 @@ Who:	Jean Delvare <[email protected]>
 ---------------------------
-
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-
----------------------------

kernel/printk.c +0 -3

index a30fe33..296c4ea 100644
@@ -560,15 +560,2 @@ static int printk_time = 0;
 module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
-
-static int __init printk_time_setup(char *str)
-{

kernel/printk.c static int printk_time = 0; · line 573

Quoted 10 lines

kernel/printk.c +0 ~~-10~~

-	if (*str)
-		return 0;
-	printk_time = 1;
-	printk(KERN_NOTICE "The 'time' option is deprecated and "
-		"is scheduled for removal in early 2008\n");
-	printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n");
-	return 1;
-}
-
-__setup("time", printk_time_setup);

---
~Randy
desserts: http://www.xenotime.net/linux/recipes/

Adrian Bunk

author

2008-01-20 14:03 UTC #4 lore raw

PATCH 1/1 the scheduled 'time' option removal

Quoted 6 lines · Randy Dunlap

Quoted 3 lines · On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote:
This patch contains the scheduled removal of the 'time' option.
Signed-off-by Adrian Bunk <[email protected]>

Quoted 7 lines

Thanks. Looks good except that Documentation/kernel-parameters.txt needs a patch also: delete these 3 lines:
time Show timing data prefixed to each printk message line
[deprecated, see 'printk.time']
then I will Ack it.

Ups, sorry, fixed patch below.

cu
Adrian

<-- snip -->

This patch contains the scheduled removal of the 'time' option.

Signed-off-by Adrian Bunk <[email protected]>

---

 Documentation/feature-removal-schedule.txt |    8 --------
 Documentation/kernel-parameters.txt        |    3 ---
 kernel/printk.c                            |   13 -------------
 3 files changed, 24 deletions(-)

84ec4030ca61db7f80b6d761acb7d12255cc5cf6

Documentation/feature-removal-schedule.txt +0 -8

index 20c4c8b..93aac19 100644
@@ -233,14 +233,6 @@ Who:	Jean Delvare <[email protected]>
 
 ---------------------------
 
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-
----------------------------
-
 What:  drivers depending on OSS_OBSOLETE
 When:  options in 2.6.23, code in 2.6.25
 Why:   obsolete OSS drivers

Documentation/kernel-parameters.txt +0 -3

index c417877..79afb11 100644
@@ -1899,9 +1899,6 @@ and is between 256 and 4096 characters. It is defined in the file
 			<deci-seconds>: poll all this frequency
 			0: no polling (default)
 
-	time		Show timing data prefixed to each printk message line
-			[deprecated, see 'printk.time']
-
 	tipar.timeout=	[HW,PPT]
 			Set communications timeout in tenths of a second
 			(default 15).

kernel/printk.c +0 ~~-13~~

index 89011bf..3aa8749 100644
@@ -560,19 +560,6 @@ static int printk_time = 0;
 #endif
 module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
 
-static int __init printk_time_setup(char *str)
-{
-	if (*str)
-		return 0;
-	printk_time = 1;
-	printk(KERN_NOTICE "The 'time' option is deprecated and "
-		"is scheduled for removal in early 2008\n");
-	printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n");
-	return 1;
-}
-
-__setup("time", printk_time_setup);
-
 __attribute__((weak)) unsigned long long printk_clock(void)
 {
 	return sched_clock();

Randy Dunlap

Acked-by on v1 1/1

2008-01-20 17:32 UTC #5 lore raw

Quoted 20 lines · Adrian Bunk

Quoted 4 lines · Randy Dunlap
Quoted 2 lines · On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote:
This patch contains the scheduled removal of the 'time' option.
Quoted 8 lines
Quoted 1 line
Signed-off-by Adrian Bunk <[email protected]>
Thanks. Looks good except that Documentation/kernel-parameters.txt needs a patch also: delete these 3 lines:
time Show timing data prefixed to each printk message line
[deprecated, see 'printk.time']
then I will Ack it.
Ups, sorry, fixed patch below.
cu
Adrian

Quoted 6 lines

<-- snip -->
This patch contains the scheduled removal of the 'time' option.
Signed-off-by Adrian Bunk <[email protected]>

Acked-by Randy Dunlap <[email protected]>

Thanks, Adrian.

Quoted 65 lines

---

 Documentation/feature-removal-schedule.txt |    8 --------
 Documentation/kernel-parameters.txt        |    3 ---
 kernel/printk.c                            |   13 -------------
 3 files changed, 24 deletions(-)

84ec4030ca61db7f80b6d761acb7d12255cc5cf6 diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 20c4c8b..93aac19 100644

Documentation/feature-removal-schedule.txt +0 -8

@@ -233,14 +233,6 @@ Who:	Jean Delvare <[email protected]>
 
 ---------------------------
 
-What:	'time' kernel boot parameter
-When:	January 2008
-Why:	replaced by 'printk.time=<value>' so that printk timestamps can be
-	enabled or disabled as needed
-Who:	Randy Dunlap <[email protected]>
-
----------------------------
-
 What:  drivers depending on OSS_OBSOLETE
 When:  options in 2.6.23, code in 2.6.25
 Why:   obsolete OSS drivers

Documentation/kernel-parameters.txt +0 -3

index c417877..79afb11 100644
@@ -1899,9 +1899,6 @@ and is between 256 and 4096 characters. It is defined in the file
 			<deci-seconds>: poll all this frequency
 			0: no polling (default)
 
-	time		Show timing data prefixed to each printk message line
-			[deprecated, see 'printk.time']
-
 	tipar.timeout=	[HW,PPT]
 			Set communications timeout in tenths of a second
 			(default 15).

kernel/printk.c +0 ~~-13~~

index 89011bf..3aa8749 100644
@@ -560,19 +560,6 @@ static int printk_time = 0;
 #endif
 module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR);
 
-static int __init printk_time_setup(char *str)
-{
-	if (*str)
-		return 0;
-	printk_time = 1;
-	printk(KERN_NOTICE "The 'time' option is deprecated and "
-		"is scheduled for removal in early 2008\n");
-	printk(KERN_NOTICE "Use 'printk.time=<value>' instead\n");
-	return 1;
-}
-
-__setup("time", printk_time_setup);
-
 __attribute__((weak)) unsigned long long printk_clock(void)
 {
 	return sched_clock();

Signature · 1 line

~Randy