ssb: Fix probing of PCI cores if PCI and PCIE core is available

PATCH New Michael Buesch 1 participant 1 message Jan 3, 2008 Sonics silicon backplane driver (ssb)

Share & tools

Michael Buesch

author

2008-01-03 18:01 UTC #0 lore raw

PATCH 1/1 ssb: Fix probing of PCI cores if PCI and PCIE core is available

This will make sure that always the correct core is selected, even if there are both a PCI and PCI-E core on a PCI or PCI-E card.

Signed-off-by Michael Buesch <[email protected]>

---

John, as this is a bugfix it should probably go into 2.6.24.

drivers/ssb/scan.c +11 -0

Index: wireless-2.6/drivers/ssb/scan.c
===================================================================
@@ -388,6 +388,17 @@ int ssb_bus_scan(struct ssb_bus *bus,
 		case SSB_DEV_PCI:
 		case SSB_DEV_PCIE:
 #ifdef CONFIG_SSB_DRIVER_PCICORE
+			if (bus->bustype == SSB_BUSTYPE_PCI) {
+				/* Ignore PCI cores on PCI-E cards.
+				 * Ignore PCI-E cores on PCI cards. */
+				if (dev->id.coreid == SSB_DEV_PCI) {
+					if (bus->host_pci->is_pcie)
+						continue;
+				} else {
+					if (!bus->host_pci->is_pcie)
+						continue;
+				}
+			}
 			if (bus->pcicore.dev) {
 				ssb_printk(KERN_WARNING PFX
 					   "WARNING: Multiple PCI(E) cores found\n");