Skip to contentSkip to conversation

USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm

PATCH Al Boldi 5 participants 7 messages Jan 5, 2008 Arm (32-bit)

lore
Share & tools
lore
#1 lore raw

Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

Quoted 16 lines · Al Boldi

From: David Brownell <[email protected]>

Source "drivers/usb/gadget/Kconfig" for ARCH=arm.

Cc David Brownell <[email protected]>
Cc Greg KH <[email protected]>
Cc Andrew Morton <[email protected]>

---

arch/arm/Kconfig source "drivers/hid/Kconfig" · line 1056

Quoted 8 lines
arch/arm/Kconfig +2 -0
@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
 
 source "drivers/usb/Kconfig"
 
+source "drivers/usb/gadget/Kconfig"
+
 source "drivers/mmc/Kconfig"
 
 source "drivers/rtc/Kconfig"

What is preventing ARM from using drivers/Kconfig? That a better fix IMO.

Sam

#2 lore raw

Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

Quoted 20 lines · Sam Ravnborg
Quoted 19 lines · Al Boldi

From: David Brownell <[email protected]>

Source "drivers/usb/gadget/Kconfig" for ARCH=arm.

Cc David Brownell <[email protected]>
Cc Greg KH <[email protected]>
Cc Andrew Morton <[email protected]>

---

arch/arm/Kconfig +0 -0
@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
 
 source "drivers/usb/Kconfig"
 
Quoted 8 lines

arch/arm/Kconfig source "drivers/hid/Kconfig" · line 1056

Quoted 5 lines
arch/arm/Kconfig +2 -0
+source "drivers/usb/gadget/Kconfig"
+
 source "drivers/mmc/Kconfig"
 
 source "drivers/rtc/Kconfig"

What is preventing ARM from using drivers/Kconfig? That a better fix IMO.

Not everything in drivers/ is suitable for every ARM configuration. It was felt at the time better for ARM to remain separate because people didn't want to pollute drivers/Kconfig with the ARM specific conditionals.

(mtd is conditional because it's not supported on ARM CPUs without alignment trap support.)

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#3 lore raw

Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

Quoted 25 lines · Russell King
Quoted 24 lines · Sam Ravnborg
Quoted 23 lines · Al Boldi

From: David Brownell <[email protected]>

Source "drivers/usb/gadget/Kconfig" for ARCH=arm.

Cc David Brownell <[email protected]>
Cc Greg KH <[email protected]>
Cc Andrew Morton <[email protected]>

---

arch/arm/Kconfig +2 -0
@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
 
 source "drivers/usb/Kconfig"
 
+source "drivers/usb/gadget/Kconfig"
+
 source "drivers/mmc/Kconfig"
 
Quoted 9 lines
Quoted 4 lines

arch/arm/Kconfig source "drivers/hid/Kconfig" · line 1056

Quoted 1 line
arch/arm/Kconfig +0 -0
 source "drivers/rtc/Kconfig"

What is preventing ARM from using drivers/Kconfig? That a better fix IMO.

Not everything in drivers/ is suitable for every ARM configuration. It was felt at the time better for ARM to remain separate because people didn't want to pollute drivers/Kconfig with the ARM specific conditionals.

Today we would have used HAVE_ for the problematic parts and thus it would have been easy to not select what ARM does not support. But unfortunately thats not how it got designed.

It would be nice to revist one day to see how much is actually needed to cleanly supprt ARM in drivers/Kconfig.

Sam

#4 lore raw

Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

Quoted 5 lines · Sam Ravnborg
Quoted 4 lines · Russell King

Not everything in drivers/ is suitable for every ARM configuration. It was felt at the time better for ARM to remain separate because people didn't want to pollute drivers/Kconfig with the ARM specific conditionals.

Quoted 7 lines

Today we would have used HAVE_ for the problematic parts and thus it would have been easy to not select what ARM does not support. But unfortunately thats not how it got designed.

It would be nice to revist one day to see how much is actually needed to cleanly supprt ARM in drivers/Kconfig.

You could diff the two Kconfig files - I try to keep them so they list the same Kconfigs in the same order to keep the diff size down.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#5 lore raw

Re: Can ARM use drivers/Kconfig [Was: Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm]

In reply to Russell King
Quoted 3 lines · Russell King

Not everything in drivers/ is suitable for every ARM configuration.  It was felt at the time better for ARM to remain separate because people didn't want to pollute drivers/Kconfig with the ARM specific conditionals.

We made drivers/Kconfig work for s390 in the meantime, which is far more special than arm in this regard, so I think you should try to give it another go.

What are the main obstacles on arm that prevent you from building these drivers?

	Arnd <><
#6 lore raw
In reply to Al Boldi

arch/arm/Kconfig source "drivers/hid/Kconfig" · line 1056

Quoted 13 lines
arch/arm/Kconfig +2 -0
@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
 
 source "drivers/usb/Kconfig"
 
+source "drivers/usb/gadget/Kconfig"
+
 source "drivers/mmc/Kconfig"
 
 source "drivers/rtc/Kconfig"

Better IMO to include such updates with the patch that reorganizes that part of the menu ... it's conceptually a single change, and fragmenting it will cause bisection problems.

In fact, moving the gadget Kconfig in a separate step would make your main changes more clear too.