Skip to contentSkip to conversation

Forcing modes in libata (was: SATA buffered read VERY slow)

DISCUSSION Applied Al Boldi 5 participants 9 messages Jan 5, 2008 – Jan 11, 2008 1 message not in the archive Documentation

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 2 lines · Alan Cox

hdparm supports identify to read modes on drives with libata. The one thing you cannot do is force modes right now.

I have some AOpen 52x/32x CD-RWriter, that advertises itself as DMA capable, but has a hard time sustaining such access. The only way to make access to this drive safe is by reducing it to PIO-3 even on XP, which makes libata somewhat unusable on this drive, especially for writing.

What's hindering the ability to force a mode in libata, as is possible with the normal ide-driver?

Thanks!

--
Al

#1 lore raw
Quoted 2 lines · On Sat, 5 Jan 2008 16:41:03 +0300 Al Boldi <[email protected]> wrote:

What's hindering the ability to force a mode in libata, as is possible with the normal ide-driver?

We want it to be correct and race free. That means we have to synchronize all the devices on the controller, quiesce them and recompute the speeds for each device then turn them all back on and resume command processing.

It is quite hairy although Tejun's EH work has provided the framework for all of this.

For now you can boot with libata.dma=1 to select DMA on disks but not CD

author
#2 lore raw
Quoted 4 lines · Alan Cox
Quoted 2 lines · Al Boldi

What's hindering the ability to force a mode in libata, as is possible with the normal ide-driver?

Quoted 8 lines

We want it to be correct and race free. That means we have to synchronize all the devices on the controller, quiesce them and recompute the speeds for each device then turn them all back on and resume command processing.

It is quite hairy although Tejun's EH work has provided the framework for all of this.

For now you can boot with libata.dma=1 to select DMA on disks but not CD

Great, but why isn't this in the documentation?

Thanks!

--
Al

#3 lore raw

On Sun, 6 Jan 2008 08:03:31 +0300

Quoted 3 lines
Quoted 1 line

For now you can boot with libata.dma=1 to select DMA on disks but not CD

Great, but why isn't this in the documentation?

Send patches

#4 lore raw
Quoted 7 lines · On Sun, 6 Jan 2008 13:36:09 +0000 Alan Cox <[email protected]> wrote:

On Sun, 6 Jan 2008 08:03:31 +0300

Quoted 4 lines
Quoted 2 lines

For now you can boot with libata.dma=1 to select DMA on disks but not CD

Great, but why isn't this in the documentation?

Send patches

patch attached.

Description : Add libata.dma= to Documentation/kernel-parameters.txt

Found documentation in :
http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg09849.html
http://www.redhat.com/archives/fedora-extras-commits/2007-October/msg04568.html

Documentation/kernel-parameters.txt +7 -0
diff -rU2 linux-2.6.24-rc6/Documentation/kernel-parameters.txt linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt
@@ -883,4 +883,11 @@
 			C2 power state.
 
+	libata.dma=	[LIBATA] DMA control
+			libata.dma=0	  Disable all PATA DMA like old IDE
+			libata.dma=1	  Disk DMA only
+			libata.dma=2	  ATAPI DMA only
+			libata.dma=3	  CF DMA only 
+			libata.dma=0,1,3  Combinations also work.
+
 	libata.noacpi	[LIBATA] Disables use of ACPI in libata suspend/resume
 			when set.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 33 lines · On Sun, 6 Jan 2008 17:27:38 +0100 Bartlomiej Zolnierkiewicz…
Quoted 13 lines · FD Cami
Quoted 7 lines · On Sun, 6 Jan 2008 13:36:09 +0000 Alan Cox <[email protected]> wrote:

On Sun, 6 Jan 2008 08:03:31 +0300

Quoted 4 lines
Quoted 2 lines

For now you can boot with libata.dma=1 to select DMA on disks but not CD

Great, but why isn't this in the documentation?

Send patches

patch attached.

Quoted 7 lines

Description : Add libata.dma= to Documentation/kernel-parameters.txt

Found documentation in :
http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg09849.html
http://www.redhat.com/archives/fedora-extras-commits/2007-October/msg04568.html

diff -rU2 linux-2.6.24-rc6/Documentation/kernel-parameters.txt linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt
---
linux-2.6.24-rc6/Documentation/kernel-parameters.txt        2008-01-06 15:58:54.000000000 +0100 +++ linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt   2008-01-06 16:11:20.000000000 +0100 @@ -883,4 +883,11 @@ C2 power state. +       libata.dma=     [LIBATA] DMA control
+                       libata.dma=0      Disable all PATA DMA like old IDE

Quoted 3 lines

this doesn't seem entirely correct:

* IDE has "hdx=nodma" so you can disable DMA on per-device basis

I think that libata.dma=1 is designed to behave like CONFIG_IDEDMA_ONLYDISK used to. "hdx=nodma" is more fine-grained than this.

Quoted 1 line

* is this really limited to PATA?

Alan's original patch took care of PATA. SATA support was added later by Jeff Garzik. Corrected documentation patch attached.

Quoted 3 lines

+                       libata.dma=1      Disk DMA only +                       libata.dma=2      ATAPI DMA only +                       libata.dma=3      CF DMA only

This is also wrong, it should be "libata.dma=4      CF DMA only" Thanks to Zoltan Boszormenyi <[email protected]> for catching this mistake.

Revised patch attached.

Best,

François

Documentation/kernel-parameters.txt +8 -0
diff -rU4 linux-2.6.24-rc6/Documentation/kernel-parameters.txt linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt
@@ -881,8 +881,16 @@
 
 	lapic_timer_c2_ok	[X86-32,x86-64,APIC] trust the local apic timer in
 			C2 power state.
 
+	libata.dma=	[LIBATA] DMA control
+			libata.dma=0	  Disable all PATA and SATA DMA
+			libata.dma=1	  PATA and SATA Disk DMA only
+			libata.dma=2	  ATAPI (CDROM) DMA only
+			libata.dma=4	  Compact Flash DMA only 
+			Combinations also work, so libata.dma=3 enables DMA
+			for disks and CDROMs, but not CFs.
+
 	libata.noacpi	[LIBATA] Disables use of ACPI in libata suspend/resume
 			when set.
 			Format: <int>
 
#7 lore raw
Quoted 36 lines · FD Cami
Quoted 33 lines · On Sun, 6 Jan 2008 17:27:38 +0100 Bartlomiej Zolnierkiewicz…
Quoted 13 lines · FD Cami
Quoted 7 lines · On Sun, 6 Jan 2008 13:36:09 +0000 Alan Cox <[email protected]> wrote:

On Sun, 6 Jan 2008 08:03:31 +0300

Quoted 4 lines
Quoted 2 lines

For now you can boot with libata.dma=1 to select DMA on disks but not CD

Great, but why isn't this in the documentation?

Send patches

patch attached.

Quoted 7 lines

Description : Add libata.dma= to Documentation/kernel-parameters.txt

Found documentation in :
http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg09849.html
http://www.redhat.com/archives/fedora-extras-commits/2007-October/msg04568.html

diff -rU2 linux-2.6.24-rc6/Documentation/kernel-parameters.txt linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt
---
linux-2.6.24-rc6/Documentation/kernel-parameters.txt        2008-01-06 15:58:54.000000000 +0100 +++ linux-2.6.24-rc6-mine/Documentation/kernel-parameters.txt   2008-01-06 16:11:20.000000000 +0100 @@ -883,4 +883,11 @@ C2 power state. +       libata.dma=     [LIBATA] DMA control
+                       libata.dma=0      Disable all PATA DMA like old IDE

Quoted 7 lines
Quoted 3 lines

this doesn't seem entirely correct:

* IDE has "hdx=nodma" so you can disable DMA on per-device basis

I think that libata.dma=1 is designed to behave like CONFIG_IDEDMA_ONLYDISK used to. "hdx=nodma" is more fine-grained than this.

Seems so but CONFIG_IDEDMA_ONLYDISK was removed on the same day that "hdx=nodma" was introduced (Oct 16 2007)...

Quoted 9 lines
Quoted 1 line

* is this really limited to PATA?

Alan's original patch took care of PATA. SATA support was added later by Jeff Garzik. Corrected documentation patch attached.

Quoted 3 lines

+                       libata.dma=1      Disk DMA only +                       libata.dma=2      ATAPI DMA only +                       libata.dma=3      CF DMA only

Quoted 5 lines

This is also wrong, it should be "libata.dma=4      CF DMA only" Thanks to Zoltan Boszormenyi <[email protected]> for catching this mistake.

Revised patch attached.

Thanks, looks good to me.

Bart

Applied
#8 lore raw

Re: [PATCH] Re: Forcing modes in libata

In reply to FD Cami
Quoted 6 lines · FD Cami

Revised patch attached.

Best,

François

applied. please include signed-off-by lines in the future...

#9 lore raw

Re: [PATCH] Re: Forcing modes in libata

Hi,

Quoted 9 lines · On Thu, 10 Jan 2008 16:56:10 -0500 Jeff Garzik <[email protected]> wrote:
Quoted 6 lines · FD Cami

Revised patch attached.

Best,

François

applied. please include signed-off-by lines in the future...

Will do. Thanks !

François