Skip to contentSkip to conversation

MCFG ACPI patch in git-x86 causes boot regression

DISCUSSION Andi Kleen 4 participants 9 messages Jan 7, 2008 – Jan 9, 2008 1 message not in the archive

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

This patch

commit c5182babd1d0706f1294af7b8dbf64e378b066bb

Author: Robert Hancock <[email protected]>
Date:   Sat Jan 5 13:26:32 2008 +0100

x86: validate against ACPI motherboard resources

...

recently added to git-x86 causes one of my Intel test systems to not boot unless I specify pci=conf1.

...
ACPI: EC: Look up EC in DSDT
ACPI: Interpreter enabled
ACPI: (supports S0 S3 S4 S5)
ACPI: Using IOAPIC for interrupt routing
PCI: MCFG configuration 0: base 4026531840 segment 0 buses 0 - 127
PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
PCI: Using MMCONFIG at f0000000 - f7ffffff
ACPI: PCI Root Bridge [PCI0] (0000:00)
<hang>

The system is a SDV, but I believe production level. DSDT is available at http://firstfloor.org/~andi/dsdt.dsl

On previous kernels the MCFG was rejected because it wasn't e820 reserved:

ACPI: bus type pci registered
PCI: BIOS Bug: MCFG area at f0000000 is not E820-reserved
PCI: Not using MMCONFIG.
PCI: Using configuration type 1

Also I'm a little surprised to find my Signed-off-by on that patch.

-Andi

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 25 lines · Jesse Barnes
Quoted 24 lines · On Monday, January 07, 2008 2:47 Andi Kleen wrote:

This patch

commit c5182babd1d0706f1294af7b8dbf64e378b066bb

Author: Robert Hancock <[email protected]>
Date:   Sat Jan 5 13:26:32 2008 +0100

x86: validate against ACPI motherboard resources

...

recently added to git-x86 causes one of my Intel test systems to not boot unless I specify pci=conf1.

...
ACPI: EC: Look up EC in DSDT
ACPI: Interpreter enabled
ACPI: (supports S0 S3 S4 S5)
ACPI: Using IOAPIC for interrupt routing
PCI: MCFG configuration 0: base 4026531840 segment 0 buses 0 - 127
PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
PCI: Using MMCONFIG at f0000000 - f7ffffff
ACPI: PCI Root Bridge [PCI0] (0000:00)
<hang>

Quoted 7 lines
Quoted 5 lines

The system is a SDV, but I believe production level. DSDT is available at http://firstfloor.org/~andi/dsdt.dsl

On previous kernels the MCFG was rejected because it wasn't e820 reserved:

Yep, this patch (as was stated many times) requires other fixes to PCI probing--either disabling decode, not using mmconfig unless absolutely required, or one of the other discussed changes. I'm not sure why it was pushed before one of those changes went in.

I believe that such a change is in Greg KH's tree. So -mm (with both trees) would probably work.

author
#3 lore raw
Quoted 1 line · Robert Hancock

Jesse Barnes wrote:

Hmm -- I didn't see Jesse's mail?

Quoted 2 lines

I believe that such a change is in Greg KH's tree. So -mm (with both trees) would probably work.

Yes 2.6.24-rc6-mm1 works, but plain git-x86 does not:

PCI: MCFG configuration 0: base 4026531840 segment 0 buses 0 - 127
PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
PCI: Using MMCONFIG at f0000000 - f7ffffff

-Andi

Quoted 1 line
#4 lore raw
Quoted 5 lines · Andi Kleen
Quoted 1 line · Robert Hancock

Jesse Barnes wrote:

Hmm -- I didn't see Jesse's mail?

Quoted 7 lines
Quoted 1 line

I believe that such a change is in Greg KH's tree. So -mm (with both trees) would probably work.

Yes 2.6.24-rc6-mm1 works, but plain git-x86 does not:

PCI: MCFG configuration 0: base 4026531840 segment 0 buses 0 - 127
PCI: MCFG area at f0000000 reserved in ACPI motherboard resources
PCI: Using MMCONFIG at f0000000 - f7ffffff

At least, I thought it was in Greg's tree, not sure now.. This is the patch in -mm:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/pci-disable-decoding-during-sizing-of-bars.patch

Without this change a bunch of machines fail to boot even without the MCFG change (since their MCFG was E820 reserved and so the old validation check passed).

#5 lore raw
Quoted 8 lines · Robert Hancock

At least, I thought it was in Greg's tree, not sure now.. This is the patch in -mm:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/pci-disable-decoding-during-sizing-of-bars.patch

Without this change a bunch of machines fail to boot even without the MCFG change (since their MCFG was E820 reserved and so the old validation check passed).

Andi, can you confirm that your box boots fine with that patch applied?

Ingo

author
#6 lore raw
Quoted 6 lines · Ingo Molnar
Quoted 3 lines · Robert Hancock

At least, I thought it was in Greg's tree, not sure now.. This is the patch in -mm:

Quoted 7 lines
Quoted 5 lines

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/pci-disable-decoding-during-sizing-of-bars.patch

Without this change a bunch of machines fail to boot even without the MCFG change (since their MCFG was E820 reserved and so the old validation check passed).

Andi, can you confirm that your box boots fine with that patch applied?

Yes it does.

-Andi

#7 lore raw
Quoted 10 lines · Andi Kleen
Quoted 8 lines
Quoted 5 lines

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/pci-disable-decoding-during-sizing-of-bars.patch

Without this change a bunch of machines fail to boot even without the MCFG change (since their MCFG was E820 reserved and so the old validation check passed).

Andi, can you confirm that your box boots fine with that patch applied?

Yes it does.

thanks for testing it. (and thanks for finding & reporting the problem) I've added that patch to x86.git, right before:

Subject: x86: validate against ACPI motherboard resources

this should be the only dependency AFAICS.

Ingo

#8 lore raw
Quoted 12 lines · On Tuesday, January 08, 2008 8:27 Ingo Molnar wrote:
Quoted 11 lines · Andi Kleen
Quoted 10 lines
Quoted 7 lines

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/
2.6.24-rc6/2.6.24-rc6-mm1/broken-out/pci-disable-decoding-during -sizing-of-bars.patch

Without this change a bunch of machines fail to boot even without the MCFG change (since their MCFG was E820 reserved and so the old validation check passed).

Andi, can you confirm that your box boots fine with that patch applied?

Quoted 8 lines
Quoted 1 line

Yes it does.

thanks for testing it. (and thanks for finding & reporting the problem) I've added that patch to x86.git, right before:

Subject: x86: validate against ACPI motherboard resources

this should be the only dependency AFAICS.

Yeah, that should work afaik, thanks for sorting this out.

Jesse

#9 lore raw
In reply to a message not in the archive
Quoted 7 lines · Jesse Barnes
Quoted 2 lines

On previous kernels the MCFG was rejected because it wasn't e820 reserved:

Yep, this patch (as was stated many times) requires other fixes to PCI probing--either disabling decode, not using mmconfig unless absolutely required, or one of the other discussed changes. I'm not sure why it was pushed before one of those changes went in.

yeah - we try to pick up patches early into x86.git, so that integration issues can be found as early as possible. But this patch should live in Greg's tree - just sent it back.

Ingo