Skip to contentSkip to conversation

checkpatch: add filename before the summary line

PATCH Paolo Ciarrocchi 2 participants 3 messages Jan 13, 2008 – Jan 14, 2008 Checkpatch

lore
Share & tools
lore
#0 lore raw

With the patch applied the output of checkpatch.pl is as follow:
./arch/arm/mach-footbridge/ebsa285-pci.c
total: 1 errors, 0 warnings, 48 lines checked

Adding the file name allowed me to collects stats running:

	find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total

but I though it might me useful for other purposes to add the file name after the list of errors and warnings and before the summary, when the list is long I find handy to print out the filename as a reminder.

scripts/checkpatch.pl +1 -0
index 579f50f..079c73c 100755
@@ -1580,6 +1580,7 @@ sub process {
 
 	print report_dump();
 	if ($summary) {
+		print "$filename \n";
 		print "total: $cnt_error errors, $cnt_warn warnings, " .
 			(($check)? "$cnt_chk checks, " : "") .
 			"$cnt_lines lines checked\n";
#1 lore raw
Quoted 9 lines · Paolo Ciarrocchi

With the patch applied the output of checkpatch.pl is as follow:
./arch/arm/mach-footbridge/ebsa285-pci.c
total: 1 errors, 0 warnings, 48 lines checked

Adding the file name allowed me to collects stats running:

	find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total

but I though it might me useful for other purposes to add the file name after the list of errors and warnings and before the summary, when the list is long I find handy to print out the filename as a reminder.

Hmmm, that being unconfitional would probabally break a raft of other users. Also would it be more useful to put it on the front of the summary line? So that if you have a bunch of files to check then you get something more like:

foo: total: 1 errors, ...
bar: total: 0 errors, ...

-apw

#2 lore raw
Quoted 11 lines · Andy Whitcroft
Quoted 9 lines · Paolo Ciarrocchi

With the patch applied the output of checkpatch.pl is as follow:
./arch/arm/mach-footbridge/ebsa285-pci.c
total: 1 errors, 0 warnings, 48 lines checked

Adding the file name allowed me to collects stats running:

      find . -name *.c |xargs ./scripts/checkpatch.pl --file |grep -B 1 total

but I though it might me useful for other purposes to add the file name after the list of errors and warnings and before the summary, when the list is long I find handy to print out the filename as a reminder.

Quoted 7 lines

Hmmm, that being unconfitional would probabally break a raft of other users. Also would it be more useful to put it on the front of the summary line? So that if you have a bunch of files to check then you get something more like:

foo: total: 1 errors, ...
bar: total: 0 errors, ...

I have a patch that adds an option (default to false) and with that I have the following output:

./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked ./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked

Will send to the list in a few minutes.

Ciao,

Signature · 2 lines
Paolo
http://paolo.ciarrocchi.googlepages.com/