Skip to contentSkip to conversation

fs/hfs/btree.c: new NULL dereference

DISCUSSION Adrian Bunk 2 participants 2 messages Jan 14, 2008

lore
Share & tools
lore
#0 lore raw

The Coverity checker spotted the following NULL dereference introduced by commit cf0594625083111ae522496dc1c256f7476939c2:

<-- snip -->

...
struct hfs_btree *hfs_btree_open(struct super_block *sb, u32 id, btree_keycmp keycmp) {
...

        if (!tree->inode)
                goto free_tree;
...
 free_tree:
        tree->inode->i_mapping->a_ops = &hfs_aops;

...

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 2 lines · Adrian Bunk

The Coverity checker spotted the following NULL dereference introduced by commit cf0594625083111ae522496dc1c256f7476939c2:

Oops. Thanks, Adrian.

Patch sent on a different thread, following another fixup patch for Roman - you're cc'd.

Thanks,

-Eric