at91_mci: minor cleanup
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 at91_mci: minor cleanup
From: Marc Pignat <[email protected]>
MMC_POWER_ON is a noop, no need to set the power pin again.
---
MMC_POWER_OFF/MMC_POWER_UP turn the power OFF/ON, there is nothing to change when ios->power_mode==MMC_POWER_ON.
Also changed indentation for the switch (CodingStyle), because there is no other switch statement in this driver.
drivers/mmc/host/at91_mci.c +0 -0
@@ -658,13 +658,14 @@ static void at91_mci_set_ios(struct mmc_
/* maybe switch power to the card */
if (host->board->vcc_pin) {
switch (ios->power_mode) {- case MMC_POWER_OFF:
- at91_set_gpio_value(host->board->vcc_pin, 0);
- break;
- case MMC_POWER_UP:
- case MMC_POWER_ON:
- at91_set_gpio_value(host->board->vcc_pin, 1);
- break;
+ case MMC_POWER_OFF:
+ at91_set_gpio_value(host->board->vcc_pin, 0);
+ break;
+ case MMC_POWER_UP:
+ at91_set_gpio_value(host->board->vcc_pin, 1);
+ break;
+ default:
+ break; } } }
Quoted 7 lines · On Wed, 30 Jan 2008 17:45:48 +0100 Nicolas Ferre <[email protected]>…
From: Marc Pignat <[email protected]>
MMC_POWER_ONis a noop, no need to set the power pin again.Signed-off-by Marc Pignat <[email protected]>Signed-off-by Nicolas Ferre <[email protected]>---
Perhaps also a WARN_ON() or something in the default case to catch bad invokations?
Rgds
Pierre