Skip to contentSkip to conversation

resend #4: [PATCH 4/5]: add AcTux-3 board support

U-Boot-Users Michael Schwingen 3 participants 5 messages Jan 15, 2008 – Jan 16, 2008

lore
Share & tools
lore

Michael Schwingen

author
#0 lore raw
Signed-off-by Michael Schwingen <[email protected]>
board/actux3/Makefile new file +50 -0
new file mode 100644
index 0000000..f6168c3
@@ -0,0 +1,50 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS	:= actux3.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak .depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/actux3/actux3.c new file +162 -0

162 lines not on this page · raw message

board/actux3/actux3_hw.h new file +60 -0

60 lines not on this page · raw message

board/actux3/config.mk new file +4 -0
new file mode 100644
index 0000000..9a634cd
@@ -0,0 +1,4 @@
+TEXT_BASE = 0x00e00000
+
+# include NPE ethernet driver
+BOARDLIBS = cpu/ixp/npe/libnpe.a
board/actux3/u-boot.lds new file +74 -0

74 lines not on this page · raw message

include/configs/actux3.h new file +224 -0

224 lines not on this page · raw message

#1 lore raw
Quoted 23 lines · Michael Schwingen
Signed-off-by Michael Schwingen <[email protected]>
board/actux3/Makefile new file +14 -0
new file mode 100644
index 0000000..f6168c3
@@ -0,0 +1,50 @@
+#
+int dram_init (void)
+{
+	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
+	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+
+	return (0);
+}
+
+void reset_phy (void)
+{
+	int i;
+
+	/* initialize the PHY */

board/actux3/Makefile line 24

Quoted 10 lines
board/actux3/Makefile new file +10 -0
+	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
+
+	/* all LED outputs = Link/Act */
+	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
+
+	/* set all ethernet switch ports to forwarding state */
+	for (i = 1; i <= 5; i++)
+		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
+
+}

Could you specify cleary in each baord file on which do you work and please be more explicit about his constants, rather than using magic numbers.

if possible use hexa value.

Best Regards,
J.

#2 lore raw
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 10 lines
board/actux3/actux3.c new file +10 -0
+void reset_phy (void)
+{
+	int i;
+
+	/* initialize the PHY */
+	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
+
+	/* all LED outputs = Link/Act */
+	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
+
Quoted 8 lines

board/actux3/actux3.c line 162

Quoted 6 lines
board/actux3/actux3.c new file +5 -0
+	/* set all ethernet switch ports to forwarding state */
+	for (i = 1; i <= 5; i++)
+		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
+
+}

Could you specify cleary in each baord file on which do you work

???

Quoted 4 lines

and
please be more explicit about his constants, rather than using magic numbers.

The chip documentation is under NDA, so all I can do is hide away the constants by inventing useless names for them.

cu
Michael

#3 lore raw
Quoted 19 lines · Michael Schwingen
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 10 lines
board/actux3/actux3.c new file +10 -0
+void reset_phy (void)
+{
+	int i;
+
+	/* initialize the PHY */
+	miiphy_reset ("NPE0", CONFIG_PHY_ADDR);
+
+	/* all LED outputs = Link/Act */
+	miiphy_write ("NPE0", CONFIG_PHY_ADDR, 0x16, 0x0AAA);
+
Quoted 8 lines

board/actux3/actux3.c line 162

Quoted 6 lines
board/actux3/actux3.c new file +5 -0
+	/* set all ethernet switch ports to forwarding state */
+	for (i = 1; i <= 5; i++)
+		miiphy_write ("NPE0", CONFIG_PHY_ADDR + 8 + i, 0x04, 0x03);
+
+}

Could you specify cleary in each baord file on which do you work

Quoted 7 lines

???

Quoted 4 lines

and
please be more explicit about his constants, rather than using magic numbers.

The chip documentation is under NDA, so all I can do is hide away the constants by inventing useless names for them.

OK, but could at least you specify which phy it is?

Best Regards.

#4 lore raw
Quoted 10 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines
Quoted 2 lines

Could you specify cleary in each baord file on which do you work

???

Quoted 4 lines

and
please be more explicit about his constants, rather than using magic numbers.

The chip documentation is under NDA, so all I can do is hide away the constants by inventing useless names for them.

OK, but could at least you specify which phy it is?

Yes.

Any other changes before i resubmit?

cu
Michael