Skip to contentSkip to conversation

put ledstate in the keyboard notifier

PATCH New Karl Dahlke 1 participant 1 message Feb 19, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 put ledstate in the keyboard notifier

I think there is general agreement, including myself, that led state should be part of the key event, like shiftstate, and not grabbed asynchronously after the fact.
So here is the patch that would do this.
I tested it with my keyboard modules and it works.
It only changes a couple lines of code, and will really help. Thanks.

linux/keyboard.h.new renamed from linux/keyboard.h +1 -0
@@ -33,6 +33,7 @@ struct keyboard_notifier_param {
 	struct vc_data *vc;	/* VC on which the keyboard press was done */
 	int down;		/* Pressure of the key? */
 	int shift;		/* Current shift mask */
+	int ledstate;		/* Current led state */
 	unsigned int value;	/* keycode, unicode value or keysym */
 };
 
char/keyboard.c.new renamed from char/keyboard.c +1 -0
@@ -1238,6 +1238,7 @@ static void kbd_keycode(unsigned int key
 	}
 
 	param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate;
+	param.ledstate = getledstate();
 	key_map = key_maps[shift_final];
 
 	if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_KEYCODE, &param) == NOTIFY_STOP || !key_map) {