Skip to contentSkip to conversation

scheduler fix

GIT PULL Ingo Molnar 1 participant 1 message Jan 22, 2008

lore
Share & tools
lore
#0 lore raw

Linus, please pull the latest scheduler-fixes git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

it's a fix for a late-breaking bug: if the root user / admin sets the new /sys/uids/*/cpu_share tunable too low from the default 1024 then we can crash/hang. [ in sched-devel.git we've already had MIN_GROUP_SHARES for a long time to enforce this limit - but it was not backported. ]

Ingo

------------------>
Ingo Molnar (1):
sched: group scheduler, set uid share fix

 sched.c |    8 ++++++++
 1 file changed, 8 insertions(+)
kernel/sched.c +8 -0
index 37cf07a..e76b11c 100644
@@ -7153,6 +7153,14 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares)
 {
 	int i;
 
+	/*
+	 * A weight of 0 or 1 can cause arithmetics problems.
+	 * (The default weight is 1024 - so there's no practical
+	 *  limitation from this.)
+	 */
+	if (shares < 2)
+		shares = 2;
+
 	spin_lock(&tg->lock);
 	if (tg->shares == shares)
 		goto done;