Skip to contentSkip to conversation

driver: tcm825x - fix logical typo error

PATCH In review Cyrill Gorcunov 2 participants 2 messages Jan 25, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 driver: tcm825x - fix logical typo error

This patch does fix potential NULL pointer dereference due to logical typo error.

The issue is pointed out by
Guennadi Liakhovetski <[email protected]>

Signed-off-by Cyrill Gorcunov <[email protected]>

---

drivers/media/video/tcm825x.c +1 -1
Index: linux-2.6.git/drivers/media/video/tcm825x.c
===================================================================
@@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
 	sensor->platform_data = client->dev.platform_data;
 
 	if (sensor->platform_data == NULL
-	    && !sensor->platform_data->is_okay())
+	    || !sensor->platform_data->is_okay())
 		return -ENODEV;
 
 	sensor->v4l2_int_device = &tcm825x_int_device;
#1 lore raw
Quoted 14 lines · Cyrill Gorcunov

This patch does fix potential NULL pointer dereference due to logical typo error.

The issue is pointed out by
Guennadi Liakhovetski <[email protected]>

Signed-off-by Cyrill Gorcunov <[email protected]>

---

Index: linux-2.6.git/drivers/media/video/tcm825x.c
===================================================================

drivers/media/video/tcm825x.c static int tcm825x_probe(struct i2c_clie · line 857

Quoted 8 lines
drivers/media/video/tcm825x.c +1 -1
@@ -851,7 +851,7 @@ static int tcm825x_probe(struct i2c_clie
 	sensor->platform_data = client->dev.platform_data;
 
 	if (sensor->platform_data == NULL
-	    && !sensor->platform_data->is_okay())
+	    || !sensor->platform_data->is_okay())
 		return -ENODEV;
 
 	sensor->v4l2_int_device = &tcm825x_int_device;

Now that it missed 2.6.24, you probably want to send it to -stable too. Even though the patch is trivial, it might be a good idea to cc: v4l2 maintainer and / or driver author.

Thanks
Guennadi
---
Guennadi Liakhovetski