Skip to contentSkip to conversation

pci_ids: patch for Intel ICH10 DeviceID's

PATCH In review Jason Gaston 4 participants 5 messages Jan 29, 2008 – Feb 12, 2008 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci_ids: patch for Intel ICH10 DeviceID's

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +6 -0
@@ -2339,6 +2339,12 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
 #define PCI_DEVICE_ID_INTEL_IOAT_CNB	0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0	0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1	0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2	0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3	0x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_4	0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5	0x3a60
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
 #define PCI_DEVICE_ID_INTEL_IOAT_SCNB	0x65ff
 #define PCI_DEVICE_ID_INTEL_TOLAPAI_0	0x5031
#1 lore raw
Quoted 1 line · Jason Gaston

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

Jason,
two questions:
Have you submitted these to pciids.sf.net?
Where are these used in the kernel?

thanks,
grant

Quoted 18 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +6 -0
@@ -2339,6 +2339,12 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
 #define PCI_DEVICE_ID_INTEL_IOAT_CNB	0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0	0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1	0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2	0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3	0x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_4	0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5	0x3a60
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
 #define PCI_DEVICE_ID_INTEL_IOAT_SCNB	0x65ff
 #define PCI_DEVICE_ID_INTEL_TOLAPAI_0	0x5031
#2 lore raw
Quoted 26 lines

-----Original Message-----
From: Grant Grundler [mailto:[email protected]]
Sent: Monday, January 28, 2008 4:22 PM
To: Gaston, Jason D
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's

Quoted 1 line · Jason Gaston

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

Jason,
two questions:
Have you submitted these to pciids.sf.net?
Where are these used in the kernel?

thanks,
grant

Quoted 4 lines

--- linux-2.6.24/include/linux/pci_ids.h.orig 2008-01-24

14:58:37.000000000 -0800

Quoted 1 line

+++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28

15:05:41.000000000 -0800

Quoted 13 lines

include/linux/pci_ids.h line 2350

Quoted 13 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +6 -0
@@ -2339,6 +2339,12 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
 #define PCI_DEVICE_ID_INTEL_IOAT_CNB	0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0	0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1	0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2	0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3	0x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_4	0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5	0x3a60
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
 #define PCI_DEVICE_ID_INTEL_IOAT_SCNB	0x65ff
 #define PCI_DEVICE_ID_INTEL_TOLAPAI_0	0x5031

Yes, these have been submitted to pciids.sf.net. I am also in the process up updating the pci.ids strings by adding "ICH10" to them.

These pci_ids.h entries are used in the drivers/i2c/busses/i2c-i801.c driver and the /arch/x86/pci/irq.c file.

Thank you,

Jason

#3 lore raw
In reply to Jason Gaston
Quoted 9 lines · Jason Gaston

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +0 -0
@@ -2339,6 +2339,12 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e

include/linux/pci_ids.h line 2350

Quoted 10 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +6 -0
 #define PCI_DEVICE_ID_INTEL_IOAT_CNB	0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0	0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1	0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2	0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3	0x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_4	0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5	0x3a60
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
 #define PCI_DEVICE_ID_INTEL_IOAT_SCNB	0x65ff
 #define PCI_DEVICE_ID_INTEL_TOLAPAI_0	0x5031

Greg, please pick this patch quickly so that it makes it to -mm and the other patches that depend on it can be pushed there as well.

Thanks,

Signature · 1 line
Jean Delvare
#4 lore raw
Quoted 15 lines · Jean Delvare
Quoted 14 lines · Jason Gaston

This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's.

include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +4 -0
@@ -2339,6 +2339,12 @@
 #define PCI_DEVICE_ID_INTEL_MCH_PC1	0x359a
 #define PCI_DEVICE_ID_INTEL_E7525_MCH	0x359e
 #define PCI_DEVICE_ID_INTEL_IOAT_CNB	0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_0	0x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_1	0x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_2	0x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_3	0x3a1a
Quoted 8 lines

include/linux/pci_ids.h line 2350

Quoted 5 lines
include/linux/pci_ids.h renamed from include/linux/pci_ids.h.orig +2 -0
+#define PCI_DEVICE_ID_INTEL_ICH10_4	0x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_5	0x3a60
 #define PCI_DEVICE_ID_INTEL_IOAT_SNB	0x402f
 #define PCI_DEVICE_ID_INTEL_IOAT_SCNB	0x65ff
 #define PCI_DEVICE_ID_INTEL_TOLAPAI_0	0x5031

Greg, please pick this patch quickly so that it makes it to -mm and the other patches that depend on it can be pushed there as well.

Will do, give me a few hours...

thanks,

greg k-h