Skip to contentSkip to conversation

dvb/frontends/tda18271-common.c: fix off-by-one

PATCH In review Adrian Bunk 2 participants 2 messages Jan 28, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 dvb/frontends/tda18271-common.c: fix off-by-one

This patch fixes an off-by-one error spotted by the Coverity checker.

Signed-off-by Adrian Bunk <[email protected]>

---

drivers/media/dvb/frontends/tda18271-common.c renamed from drivers/media/dvb/frontends/tda18271-common.c.old +1 -1
@@ -166,17 +166,17 @@ int tda18271_read_extended(struct dvb_fr
 	/* read all registers */
 	ret = i2c_transfer(priv->i2c_adap, msg, 2);
 
 	tda18271_i2c_gate_ctrl(fe, 0);
 
 	if (ret != 2)
 		tda_err("ERROR: i2c_transfer returned: %d\n", ret);
 
-	for (i = 0; i <= TDA18271_NUM_REGS; i++) {
+	for (i = 0; i < TDA18271_NUM_REGS; i++) {
 		/* don't update write-only registers */
 		if ((i != R_EB9)  &&
 		    (i != R_EB16) &&
 		    (i != R_EB17) &&
 		    (i != R_EB19) &&
 		    (i != R_EB20))
 		regs[i] = regdump[i];
 	}
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Adrian Bunk

This patch fixes an off-by-one error spotted by the Coverity checker.

Signed-off-by Adrian Bunk <[email protected]>
Reviewed-by Michael Krufky <[email protected]>

Thank you, Adrian.

Mauro, please merge this and queue for upstream.

Cheers,

Mike

Quoted 2 lines

---
--- linux-2.6/drivers/media/dvb/frontends/tda18271-common.c.old

2008-01-28 16:27:55.000000000 +0200
Quoted 1 line

+++ linux-2.6/drivers/media/dvb/frontends/tda18271-common.c 2008-01-28

16:28:38.000000000 +0200

Quoted 21 lines
drivers/media/dvb/frontends/tda18271-common.c renamed from drivers/media/dvb/frontends/tda18271-common.c.old +1 -1
@@ -166,17 +166,17 @@ int tda18271_read_extended(struct dvb_fr
 	/* read all registers */
 	ret = i2c_transfer(priv->i2c_adap, msg, 2);
 
 	tda18271_i2c_gate_ctrl(fe, 0);
 
 	if (ret != 2)
 		tda_err("ERROR: i2c_transfer returned: %d\n", ret);
 
-	for (i = 0; i <= TDA18271_NUM_REGS; i++) {
+	for (i = 0; i < TDA18271_NUM_REGS; i++) {
 		/* don't update write-only registers */
 		if ((i != R_EB9)  &&
 		    (i != R_EB16) &&
 		    (i != R_EB17) &&
 		    (i != R_EB19) &&
 		    (i != R_EB20))
 		regs[i] = regdump[i];
 	}