Skip to contentSkip to conversation

fix lines over 80 characters

PATCH In review Paolo Ciarrocchi 2 participants 3 messages Jan 28, 2008 – Jan 31, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 7/7 fix lines over 80 characters

fix lines over 80 characters

---
 arch/x86/math-emu/errors.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
arch/x86/math-emu/errors.c +4 -2
index 569a62e..e5a5b80 100644
@@ -75,7 +75,8 @@ void FPU_printall(void)
 	  FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
 
 	  if (FPU_modrm >= 0300)
-	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
+	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
+		FPU_modrm & 7);
 	  else
 	    printk(KERN_ERR " /%d, mod=%d rm=%d\n",
 		   (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
 	printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
 
       if (n == EX_INTERNAL) {
-	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
+	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
+		int_type);
 	  FPU_printall();
 	}
 #ifdef PRINT_MESSAGES
Signature · 1 line
1.5.4.rc3
#1 lore raw
Quoted 13 lines · Paolo Ciarrocchi
arch/x86/math-emu/errors.c +2 -1
@@ -75,7 +75,8 @@ void FPU_printall(void)
 	  FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
 
 	  if (FPU_modrm >= 0300)
-	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8, FPU_modrm & 7);
+	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
+		FPU_modrm & 7);
 	  else
 	    printk(KERN_ERR " /%d, mod=%d rm=%d\n",
 		   (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);

arch/x86/math-emu/errors.c asmlinkage void FPU_exception(int n) · line 317

Quoted 9 lines
arch/x86/math-emu/errors.c +2 -1
@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
 	printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
 
       if (n == EX_INTERNAL) {
-	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n", int_type);
+	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
+		int_type);
 	  FPU_printall();
 	}
 #ifdef PRINT_MESSAGES

The "fix" is still not conforming to CodingStyle.

Besides, why don't you leave these lines as they are? There is no important information hidden behind the 80th column in the existing code.

Signature · 3 lines
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
#2 lore raw
Quoted 29 lines · Stefan Richter

arch/x86/math-emu/errors.c void FPU_printall(void) · line 78

Quoted 7 lines · Paolo Ciarrocchi
arch/x86/math-emu/errors.c +0 -1
@@ -75,7 +75,8 @@ void FPU_printall(void)
 	  FPU_get_user(FPU_modrm, 1 + (u_char __user *) address);
 
 	  if (FPU_modrm >= 0300)
-	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,

FPU_modrm & 7);

arch/x86/math-emu/errors.c asmlinkage void FPU_exception(int n) · line 312

Quoted 10 lines
arch/x86/math-emu/errors.c +2 -1
+	    printk(KERN_ERR " %02x (%02x+%d)\n", FPU_modrm, FPU_modrm & 0xf8,
+		FPU_modrm & 7);
 	  else
 	    printk(KERN_ERR " /%d, mod=%d rm=%d\n",
 		   (FPU_modrm >> 3) & 7, (FPU_modrm >> 6) & 3, FPU_modrm & 7);
@@ -309,7 +310,8 @@ asmlinkage void FPU_exception(int n)
 	printk(KERN_ERR "FPU emulator: Unknown Exception: 0x%04x!\n", n);
 
       if (n == EX_INTERNAL) {
-	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",

int_type);

arch/x86/math-emu/errors.c asmlinkage void FPU_exception(int n) · line 317

Quoted 5 lines
arch/x86/math-emu/errors.c +2 -0
+	  printk(KERN_ERR "FPU emulator: Internal error type 0x%04x\n",
+		int_type);
 	  FPU_printall();
 	}
 #ifdef PRINT_MESSAGES

The "fix" is still not conforming to CodingStyle.

Quoted 2 lines

Besides, why don't you leave these lines as they are? There is no important information hidden behind the 80th column in the existing code.

Yes, you are right.
Ingo, patch 7 deserves to be deleted.

Ciao,

Signature · 2 lines
Paolo
http://paolo.ciarrocchi.googlepages.com/