e1000e/ethtool.c: make a function static

PATCH In review Adrian Bunk 2 participants 2 messages Jan 30, 2008

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Adrian Bunk

author

2008-01-30 20:02 UTC #0 lore raw

PATCH 1/1 e1000e/ethtool.c: make a function static

This patch makes the needlessly global reg_pattern_test_array() static.

Signed-off-by Adrian Bunk <[email protected]>

---
ed72e457f06311390d9a9e51a00c904939466aff

drivers/net/e1000e/ethtool.c +2 -2

index 6d9c27f..a2034cf 100644
@@ -690,8 +690,8 @@ err_setup:
 	return err;
 }
 
-bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
-			    int reg, int offset, u32 mask, u32 write)
+static bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
+				   int reg, int offset, u32 mask, u32 write)
 {
 	int i;
 	u32 read;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Kok, Auke

2008-01-30 21:51 UTC #1 lore raw

Quoted 3 lines · Adrian Bunk

This patch makes the needlessly global reg_pattern_test_array() static.
Signed-off-by Adrian Bunk <[email protected]>

stephen hemminger already pointed this out to me... I'll certainly push this upstream, thanks Adrian!

Auke

Quoted 9 lines

---
ed72e457f06311390d9a9e51a00c904939466aff
drivers/net/e1000e/ethtool.c +0 -0
index 6d9c27f..a2034cf 100644

drivers/net/e1000e/ethtool.c err_setup: · line 697

Quoted 10 lines

drivers/net/e1000e/ethtool.c +2 -2

@@ -690,8 +690,8 @@ err_setup:
 	return err;
 }
 
-bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
-			    int reg, int offset, u32 mask, u32 write)
+static bool reg_pattern_test_array(struct e1000_adapter *adapter, u64 *data,
+				   int reg, int offset, u32 mask, u32 write)
 {
 	int i;
 	u32 read;