Skip to contentSkip to conversation

ide-scsi: remove needless SELECT_DRIVE() call

PATCH New Bartlomiej Zolnierkiewicz 1 participant 1 message Feb 2, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide-scsi: remove needless SELECT_DRIVE() call

SELECT_DRIVE() is called by IDE core code in start_request() before device driver's ->do_request method. In ide-scsi case ->do_request is implemented by idescsi_do_request() which is also the only user of idescsi_issue_pc().

---
goes before "ide: unexport SELECT_DRIVE()" patch in IDE quilt tree

 drivers/scsi/ide-scsi.c |    2 --
 1 file changed, 2 deletions(-)
drivers/scsi/ide-scsi.c +0 -2
Index: b/drivers/scsi/ide-scsi.c
===================================================================
@@ -588,8 +588,6 @@ static ide_startstop_t idescsi_issue_pc 
 		hwif->sg_mapped = 0;
 	}
 
-	SELECT_DRIVE(drive);
-
 	ide_pktcmd_tf_load(drive, IDE_TFLAG_NO_SELECT_MASK, bcount, dma);
 
 	if (dma)