Skip to contentSkip to conversation

Second round of kbuild updates

PATCH New Sam Ravnborg 3 participants 7 messages Feb 3, 2008 – Feb 5, 2008 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Second round of kbuild updates

Hi Linus.

Please pull the following changes from kbuild.git:

ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git

The diffstat say that a relative high number of files are touched. This is due to the set of patches from Mathieu that introduce an arch common Kconfig file and start utilizing it.
The rest are much simpler.

The most visible change is that I have made all the section mismatch warning prints go away and in the end of the build modpost simply report the number of section mismatch warnings and how to see detail.

The typical output is now:

modpost: Found 35 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'

And CONFIG_DEBUG_SECTION_MISMATCH cannot be set from the config anymore so we are not noisy in typical allyesconfig builds.

When we are down to an acceptable number of warnings modpost will start to be vocal again.

The section mismatch logic were changed so we no longer complain about exported symbols annotated __devinit, __cpuinit, __meminit as they all seemed to be dealt with properly and the hack needed to avoid the warnings was not worth the effort.

And I killed the irritating "select of unknown symbol warning".

The scsi change is acked by James and he said OK to get it in via kbuild.git.

Patches has been sent out for review one day ago and comments has been addressed.
As Andrew has picked up the updated kbuild.git tree I think it is easiest to get this in before Andrew starts merging his pile of patches.

Sam

Bryan Wu (1):
kbuild: add svn revision information to setlocalversion

Geert Uytterhoeven (1):
kbuild: Spelling/grammar fixes for config DEBUG_SECTION_MISMATCH

Mathieu Desnoyers (5):
Fix ARM to play nicely with generic Instrumentation menu Create arch/Kconfig
Add HAVE_OPROFILE
Add HAVE_KPROBES
Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig

Ralf Baechle (1):
Remove __INIT_REFOK and __INITDATA_REFOK

Sam Ravnborg (5):
kbuild: print only total number of section mismatces found
kconfig: mark config as changed when loading an alternate config
kconfig: ignore select of unknown symbol
kbuild: do not warn about __*init/__*exit symbols being exported
scsi: fix dependency bug in aic7 Makefile

 arch/Kconfig                     |   31 +++++++++++++++++++
 arch/alpha/Kconfig               |    3 +-
 arch/arm/Kconfig                 |   21 +++++++++++-
 arch/arm/Kconfig.instrumentation |   62 --------------------------------------
 arch/avr32/Kconfig               |    5 +--
 arch/blackfin/Kconfig            |    3 +-
 arch/cris/Kconfig                |    2 -
 arch/frv/Kconfig                 |    2 -
 arch/h8300/Kconfig               |    2 -
 arch/ia64/Kconfig                |    4 +-
 arch/m32r/Kconfig                |    3 +-
 arch/m68k/Kconfig                |    2 -
 arch/m68knommu/Kconfig           |    2 -
 arch/mips/Kconfig                |    3 +-
 arch/parisc/Kconfig              |    3 +-
 arch/powerpc/Kconfig             |    4 +-
 arch/ppc/Kconfig                 |    4 +-
 arch/s390/Kconfig                |    4 +-
 arch/sh/Kconfig                  |    3 +-
 arch/sparc/Kconfig               |    3 +-
 arch/sparc64/Kconfig             |    4 +-
 arch/um/Kconfig                  |    2 -
 arch/v850/Kconfig                |    2 -
 arch/x86/Kconfig                 |    8 +----
 arch/xtensa/Kconfig              |    2 -
 drivers/scsi/aic7xxx/Makefile    |    9 +----
 include/linux/init.h             |    3 --
 init/Kconfig                     |   14 ++++++++
 kernel/Kconfig.instrumentation   |   49 ------------------------------
 lib/Kconfig.debug                |   14 ++++----
 scripts/kconfig/mconf.c          |    1 +
 scripts/kconfig/menu.c           |    9 ++----
 scripts/mod/modpost.c            |   17 +++++-----
 scripts/setlocalversion          |   16 ++++++++++
 34 files changed, 122 insertions(+), 194 deletions(-)
#1 lore raw

PATCH 1/1 kbuild: Fix instrumentation removal breakage on avr32

Quoted 2 lines · On Sun, 3 Feb 2008 22:10:42 +0100 Sam Ravnborg <[email protected]> wrote:

Mathieu Desnoyers (5):
Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig

AVR32 still includes Kconfig.instrumentation, so it won't build after this...

I did point this out when the patch was submitted, I sent the avr32 pull request early as promised (more than a week ago), but it still broke. Please apply the fix below. This fixes 2.6.24-mm1 too.

---
 arch/avr32/Kconfig |    2 --
 1 file changed, 2 deletions(-)
arch/avr32/Kconfig +0 -2
Index: linux-2.6.24-mm1/arch/avr32/Kconfig
===================================================================
@@ -236,8 +236,6 @@ source "drivers/Kconfig"
 
 source "fs/Kconfig"
 
-source "kernel/Kconfig.instrumentation"
-
 source "arch/avr32/Kconfig.debug"
 
 source "security/Kconfig"
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] kbuild: Fix instrumentation removal breakage on avr32

Quoted 6 lines · * Haavard Skinnemoen ([email protected]) wrote:
Quoted 2 lines · On Sun, 3 Feb 2008 22:10:42 +0100 Sam Ravnborg <[email protected]> wrote:

Mathieu Desnoyers (5):
Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig

Quoted 7 lines

AVR32 still includes Kconfig.instrumentation, so it won't build after this...

I did point this out when the patch was submitted, I sent the avr32 pull request early as promised (more than a week ago), but it still broke. Please apply the fix below. This fixes 2.6.24-mm1 too.

This one slipped through.

Quoted 18 lines
---
 arch/avr32/Kconfig |    2 --
 1 file changed, 2 deletions(-)

Index: linux-2.6.24-mm1/arch/avr32/Kconfig
===================================================================

arch/avr32/Kconfig +0 -2
@@ -236,8 +236,6 @@ source "drivers/Kconfig"
 
 source "fs/Kconfig"
 
-source "kernel/Kconfig.instrumentation"
-
 source "arch/avr32/Kconfig.debug"
 
 source "security/Kconfig"
Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
#3 lore raw

Re: [PATCH] kbuild: Fix instrumentation removal breakage on avr32

In reply to Haavard Skinnemoen
Quoted 6 lines · Haavard Skinnemoen
Quoted 2 lines · On Sun, 3 Feb 2008 22:10:42 +0100 Sam Ravnborg <[email protected]> wrote:

Mathieu Desnoyers (5):
Move Kconfig.instrumentation to arch/Kconfig and init/Kconfig

Quoted 6 lines

AVR32 still includes Kconfig.instrumentation, so it won't build after this...

I did point this out when the patch was submitted, I sent the avr32 pull request early as promised (more than a week ago), but it still broke. Please apply the fix below. This fixes 2.6.24-mm1 too.

Sorry for not catching this.
I just blow away my git tree at kernel.org to avoid getting it merged with the bug but Linus was too quick for me so he already merged kbuild.git and applied this patch afterwards.

Sam

#4 lore raw

Re: [PATCH] kbuild: Fix instrumentation removal breakage on avr32

Quoted 4 lines · On Mon, 4 Feb 2008 20:46:26 +0100 Sam Ravnborg <[email protected]> wrote:

Sorry for not catching this.
I just blow away my git tree at kernel.org to avoid getting it merged with the bug but Linus was too quick for me so he already merged kbuild.git and applied this patch afterwards.

Ok, the result looks good. Thanks.

Bisecting on avr32 will be a nightmare though, but not only because of this patch...

Haavard

#5 lore raw

Re: [PATCH] kbuild: Fix instrumentation removal breakage on avr32

Quoted 8 lines · Haavard Skinnemoen
Quoted 4 lines · On Mon, 4 Feb 2008 20:46:26 +0100 Sam Ravnborg <[email protected]> wrote:

Sorry for not catching this.
I just blow away my git tree at kernel.org to avoid getting it merged with the bug but Linus was too quick for me so he already merged kbuild.git and applied this patch afterwards.

Quoted 4 lines

Ok, the result looks good. Thanks.

Bisecting on avr32 will be a nightmare though, but not only because of this patch...

This problem had not required a cross-tool chain - so no excuses but.. I recal I once had an AVR32 toolchain but I lost it when I got my new dev box.

Any pointer to a recent AVR32 toolchain I can use for test builds.

Sam

#6 lore raw

Re: [PATCH] kbuild: Fix instrumentation removal breakage on avr32

Quoted 11 lines · On Tue, 5 Feb 2008 13:03:34 +0100 Sam Ravnborg <[email protected]> wrote:
Quoted 10 lines · Haavard Skinnemoen
Quoted 4 lines · On Mon, 4 Feb 2008 20:46:26 +0100 Sam Ravnborg <[email protected]> wrote:

Sorry for not catching this.
I just blow away my git tree at kernel.org to avoid getting it merged with the bug but Linus was too quick for me so he already merged kbuild.git and applied this patch afterwards.

Ok, the result looks good. Thanks.

Quoted 7 lines
Quoted 2 lines

Bisecting on avr32 will be a nightmare though, but not only because of this patch...

This problem had not required a cross-tool chain - so no excuses but.. I recal I once had an AVR32 toolchain but I lost it when I got my new dev box.

Any pointer to a recent AVR32 toolchain I can use for test builds.

http://www.atmel.com/dyn/products/tools_card.asp?tool_id=4118

or if you want to use buildroot:

http://www.atmel.no/buildroot/

Haavard