NFSD: Use "depends on" for PROC_FS dependency
Subsystems (3)
PATCH 5/5 NFSD: Use "depends on" for PROC_FS dependency
Recently a reverse dependency was added to fs/Kconfig to ensure that PROC_FS was enabled if NFSD_V4 was enabled.
There is a guideline in Documentation/kbuild/kconfig-language.txt that states "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies."
A quick grep around other Kconfig files reveals that no entry currently uses "select PROC_FS" -- every one uses "depends on". Thus CONFIG_NFSD_V4 should use "depends on PROC_FS" as well.
For SUNRPC_GSS, it's a little more complex. Other entries can "select" SUNRPC_GSS, as it is non-visible. However, the guideline suggests an entry can't "select" it if it has a dependency (such as PROC_FS).
Another problem is that if a tristate entry (SUNRPC_GSS) "depends on" a boolean (PROC_FS) we can't set the tristate entry to M.
XXX: Both CONFIG_NFSV4 and CONFIG_NFSD_V4 select RPCSEC_GSS_KRB5, which is visible, which kconfig-language.txt also frowns upon. The intent was to enable at least one GSS mechanism if V4 was enabled. Perhaps we should make SUNRPC_GSS visible, and make the NFSv4 options visible only if SUNRPC_GSS is enabled.
---
fs/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
fs/Kconfig +1 -2
@@ -1689,7 +1689,6 @@ config NFSD select CRYPTO_MD5 if NFSD_V4 select CRYPTO if NFSD_V4 select FS_POSIX_ACL if NFSD_V4 - select PROC_FS if NFSD_V4 select PROC_FS if SUNRPC_GSS help Say Y here if you want to allow other computers to access files
@@ -1750,7 +1749,7 @@ config NFSD_V3_ACL config NFSD_V4 bool "Provide NFSv4 server support (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for
A message that is not in the archive (sent off-list or not yet received): 20080205000450.18602.4797.stgit-meopP2rzCrTwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org
Sigh. I see this is broken already.
It may be the case that "select ... if ..." is the only way to do this.
Quoted 53 lines · Chuck Lever
Recently a reverse dependency was added to fs/Kconfig to ensure that
PROC_FSwas enabled ifNFSD_V4was enabled.There is a guideline in
Documentation/kbuild/kconfig-language.txtthat states "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies."A quick grep around other
Kconfigfiles reveals that no entry currently uses "selectPROC_FS" -- every one uses "depends on". ThusCONFIG_NFSD_V4should use "depends onPROC_FS" as well.For
SUNRPC_GSS, it's a little more complex. Other entries can "select"SUNRPC_GSS, as it is non-visible. However, the guideline suggests an entry can't "select" it if it has a dependency (such asPROC_FS).Another problem is that if a tristate entry (
SUNRPC_GSS) "depends on" a boolean (PROC_FS) we can't set the tristate entry to M.XXX: Both
CONFIG_NFSV4andCONFIG_NFSD_V4selectRPCSEC_GSS_KRB5, which is visible, which kconfig-language.txt also frowns upon. The intent was to enable at least one GSS mechanism if V4 was enabled. Perhaps we should makeSUNRPC_GSSvisible, and make the NFSv4 options visible only ifSUNRPC_GSSis enabled.Signed-off-by Chuck Lever <[email protected]>---
fs/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)fs/Kconfig +1
-3@@ -1689,7 +1689,6 @@ config NFSD select CRYPTO_MD5 if NFSD_V4 select CRYPTO if NFSD_V4 select FS_POSIX_ACL if NFSD_V4 - select PROC_FS if NFSD_V4 select PROC_FS if SUNRPC_GSS help Say Y here if you want to allow other computers to access files@@ -1750,7 +1749,7 @@ config NFSD_V3_ACL config NFSD_V4 bool "Provide NFSv4 server support (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for -
Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 1 line · Chuck Lever
Sigh. I see this is broken already.
What was the problem?
--b.
Quoted 74 lines
It may be the case that "select ... if ..." is the only way to do this.
Quoted 59 lines · Chuck Lever
Recently a reverse dependency was added to fs/Kconfig to ensure that
PROC_FSwas enabled ifNFSD_V4was enabled.There is a guideline in
Documentation/kbuild/kconfig-language.txtthat states "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies."A quick grep around other
Kconfigfiles reveals that no entry currently
uses "selectPROC_FS" -- every one uses "depends on". ThusCONFIG_NFSD_V4
should use "depends onPROC_FS" as well.For
SUNRPC_GSS, it's a little more complex. Other entries can "select"SUNRPC_GSS, as it is non-visible. However, the guideline suggests an entry can't "select" it if it has a dependency (such asPROC_FS).Another problem is that if a tristate entry (
SUNRPC_GSS) "depends on" a boolean (PROC_FS) we can't set the tristate entry to M.XXX: Both
CONFIG_NFSV4andCONFIG_NFSD_V4selectRPCSEC_GSS_KRB5, which is
visible, which kconfig-language.txt also frowns upon. The intent was to
enable at least one GSS mechanism if V4 was enabled. Perhaps we should
makeSUNRPC_GSSvisible, and make the NFSv4 options visible only ifSUNRPC_GSSis enabled.Signed-off-by Chuck Lever <[email protected]>---
fs/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)fs/Kconfig +1
-3@@ -1689,7 +1689,6 @@ config NFSD select CRYPTO_MD5 if NFSD_V4 select CRYPTO if NFSD_V4 select FS_POSIX_ACL if NFSD_V4 - select PROC_FS if NFSD_V4 select PROC_FS if SUNRPC_GSS help Say Y here if you want to allow other computers to access files@@ -1750,7 +1749,7 @@ config NFSD_V3_ACL config NFSD_V4 bool "Provide NFSv4 server support (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for -Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
Quoted 4 lines · J. Bruce Fields
Quoted 1 line · Chuck Lever
Sigh. I see this is broken already.
What was the problem?
[cel@manray nfs-2.6]$ make menuconfig
GEN /u/cel/obj/Makefilescripts/kconfig/mconf arch/x86/Kconfig
fs/Kconfig:1751:error: found recursive dependency: NFSD_V4 -> RPCSEC_GSS_KRB5 -> SUNRPC_GSS -> PROC_FS -> NFSD_V4
-> CRYPTO -> CRYPTO_ANUBISmake[2]: *** [menuconfig] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [sub-make] Error 2
[cel@manray nfs-2.6]$
That may be because of the other issue I noticed: that NFSD_V4 selects RPCSEC_GSS_KRB5, which is a visible config entry.
Quoted 62 lines
Quoted 62 lines
It may be the case that "select ... if ..." is the only way to do this.
Quoted 58 lines · Chuck Lever
Recently a reverse dependency was added to fs/Kconfig to ensure that
PROC_FSwas enabled ifNFSD_V4was enabled.There is a guideline in
Documentation/kbuild/kconfig-language.txtthat states "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies."A quick grep around other
Kconfigfiles reveals that no entry currently
uses "selectPROC_FS" -- every one uses "depends on". ThusCONFIG_NFSD_V4
should use "depends onPROC_FS" as well.For
SUNRPC_GSS, it's a little more complex. Other entries can "select"SUNRPC_GSS, as it is non-visible. However, the guideline suggests an entry can't "select" it if it has a dependency (such asPROC_FS).Another problem is that if a tristate entry (
SUNRPC_GSS) "depends on" a boolean (PROC_FS) we can't set the tristate entry to M.XXX: Both
CONFIG_NFSV4andCONFIG_NFSD_V4selectRPCSEC_GSS_KRB5, which is
visible, which kconfig-language.txt also frowns upon. The intent was to
enable at least one GSS mechanism if V4 was enabled. Perhaps we should
makeSUNRPC_GSSvisible, and make the NFSv4 options visible only ifSUNRPC_GSSis enabled.Signed-off-by Chuck Lever <[email protected]>---
fs/Kconfig | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)fs/Kconfig +1
-2@@ -1689,7 +1689,6 @@ config NFSD select CRYPTO_MD5 if NFSD_V4 select CRYPTO if NFSD_V4 select FS_POSIX_ACL if NFSD_V4 - select PROC_FS if NFSD_V4 select PROC_FS if SUNRPC_GSS help Say Y here if you want to allow other computers to access files@@ -1750,7 +1749,7 @@ config NFSD_V3_ACL config NFSD_V4 bool "Provide NFSv4 server support (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && NFSD_V3 && PROC_FS && EXPERIMENTAL select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
-
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com