module: fix __find_symbl() error checks
PATCH 1/1 module: fix __find_symbl() error checks
The patch:
changes the return value of __find_symbol() so that it can handle symbols that are zero and now it returns -errno for failure.
But some __find_symbl() error checks remain unchanged.
Signed-off-by Akinobu Mita <[email protected]>
Cc Christoph Lameter <[email protected]>
--- kernel/module.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
kernel/module.c +4 -2
@@ -977,7 +977,7 @@ static unsigned long resolve_symbol(Elf_ ret =__find_symbol (name, &owner, &crc, !(mod->taints &TAINT_PROPRIETARY_MODULE )); -if (ret) { +if (!IS_ERR_VALUE (ret)) {/* use_module can fail due to OOM, or module initialization or unloading */ if (!check_version(sechdrs, versindex, name, mod, crc) ||
@@ -1370,7 +1370,9 @@ void *__symbol_get(const char *symbol)preempt_disable (); value =__find_symbol (symbol, &owner, &crc,1 ); -if (value &&strong_try_module_get (owner) !=0 ) +if (IS_ERR_VALUE (value)) + value =0 ; +else if (strong_try_module_get (owner)) value =0 ;preempt_enable ();