Skip to contentSkip to conversation

kill t_sema member of struct xfs_trans

PATCH In review Christoph Hellwig 4 participants 5 messages Feb 7, 2008 – Feb 28, 2008 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kill t_sema member of struct xfs_trans

It's completely unused so we might aswell kill it. Note that there is another t_sema in struct xlog_ticket, which is used and actually an sv_t despite the name. That one is left untouched by this patch.

fs/xfs/xfs_trans.h +0 -1
Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
===================================================================
@@ -341,7 +341,6 @@ typedef struct xfs_trans {
 	unsigned int		t_rtx_res;	/* # of rt extents resvd */
 	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
 	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
-	sema_t			t_sema;		/* sema for commit completion */
 	xfs_lsn_t		t_lsn;		/* log seq num of start of
 						 * transaction. */
 	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of
#1 lore raw
Quoted 3 lines · Christoph Hellwig

It's completely unused so we might aswell kill it. Note that there is another t_sema in struct xlog_ticket, which is used and actually an sv_t despite the name. That one is left untouched by this patch.

Ping?

Quoted 7 lines

Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
===================================================================

fs/xfs/xfs_trans.h typedef struct xfs_trans { · line 346

Quoted 7 lines
fs/xfs/xfs_trans.h +0 -1
@@ -341,7 +341,6 @@ typedef struct xfs_trans {
 	unsigned int		t_rtx_res;	/* # of rt extents resvd */
 	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
 	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
-	sema_t			t_sema;		/* sema for commit completion */
 	xfs_lsn_t		t_lsn;		/* log seq num of start of
 						 * transaction. */
 	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of

---end quoted text---

#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

It's completely unused so we might aswell kill it. Note that there is another t_sema in struct xlog_ticket, which is used and actually an sv_t despite the name. That one is left untouched by this patch.

Ping?

This seems to be already applied in our dev tree, I'm trying to track down how/when/by-who, appart from that I'm all for pushing it.

Cheers,

Signature · 1 line
Niv
#3 lore raw
Quoted 16 lines · Niv Sardi

* Christoph Hellwig <[email protected]> [2008-02-26 18:57:58 +0100]:

Index: linux-2.6-xfs/fs/xfs/xfs_trans.h
===================================================================

fs/xfs/xfs_trans.h +0 -1
@@ -341,7 +341,6 @@ typedef struct xfs_trans {
 	unsigned int		t_rtx_res;	/* # of rt extents resvd */
 	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
 	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
-	sema_t			t_sema;		/* sema for commit completion */
 	xfs_lsn_t		t_lsn;		/* log seq num of start of
 						 * transaction. */
 	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of
Quoted 2 lines · Christoph Hellwig
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

It's completely unused so we might aswell kill it. Note that there is another t_sema in struct xlog_ticket, which is used and actually an sv_t despite the name. That one is left untouched by this patch.

Ping?

This seems to be already applied in our dev tree, I'm trying to track down how/when/by-who, appart from that I'm all for pushing it.

Cheers,

Niv, it still seems to be in our dev tree for me:

Quoted 1 line

p_cat -farm xfs_trans.h | grep -C 3 t_sema

doucette  |1.22 |                            |	unsigned int		t_rtx_res;	/* # of rt extents resvd */
cattelan  |1.118|2.4.x-xfs:slinx:144573a     |	unsigned int		t_rtx_res_used;	/* # of resvd rt extents used */
ajs       |1.13 |                            |	xfs_log_ticket_t	t_ticket;	/* log mgr ticket */
ajs       |1.11 |                            |	sema_t			t_sema;		/* sema for commit completion */
lord      |1.114|2.4.x-xfs:slinx:129778a     |	xfs_lsn_t		t_lsn;		/* log seq num of start of
lord      |1.114|2.4.x-xfs:slinx:129778a     |						 * transaction. */
cattelan  |1.118|2.4.x-xfs:slinx:144573a     |	xfs_lsn_t		t_commit_lsn;	/* log seq num of end of

--Tim

#4 lore raw
Quoted 1 line · Timothy Shimmin

Niv, it still seems to be in our dev tree for me:

And if it were checked in, where's the TAKE message? :)

-Eric