Skip to contentSkip to conversation

palm_bk3710: port initialization/probing bugfix

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Feb 7, 2008 – Feb 8, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 palm_bk3710: port initialization/probing bugfix

Probe port _after_ it is fully initialized.

Cc Anton Salnikov <[email protected]>
Cc Sergei Shtylyov <[email protected]>
---
 drivers/ide/arm/palm_bk3710.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/ide/arm/palm_bk3710.c +7 -7
Index: b/drivers/ide/arm/palm_bk3710.c
===================================================================
@@ -370,13 +370,6 @@ static int __devinit palm_bk3710_probe(s
 	ide_init_port_hw(hwif, &hw);
 	hwif->quirkproc = NULL;
 
-	idx[0] = i;
-
-	ide_device_add(idx, NULL);
-
-	if (!hwif->present)
-		goto out;
-
 	hwif->set_pio_mode = &palm_bk3710_set_pio_mode;
 	hwif->set_dma_mode = &palm_bk3710_set_dma_mode;
 	hwif->mmio = 1;
@@ -390,6 +383,13 @@ static int __devinit palm_bk3710_probe(s
 
 	ide_setup_dma(hwif, mem->start);
 
+	idx[0] = i;
+
+	ide_device_add(idx, NULL);
+
+	if (!hwif->present)
+		goto out;
+
 	return 0;
 out:
 	printk(KERN_WARNING "Palm Chip BK3710 IDE Register Fail\n");