make V=1 broken
make V=1 is broken at the moment.
I do not have possibility to look at it until
in ~20 hours.
So if anyone can help until then...
To reproduce:
make defconfig
make V=1
Sam
shell command is empty, when "silent" (Re: make V=1 broken)
Quoted 11 lines · Sam Ravnborg
make V=1 is broken at the moment.
I do not have possibility to look at it until
in ~20 hours.
So if anyone can help until then...To reproduce:
make defconfig
make V=1
Somehow $(quiet) == "", when it should be "silent_". Thus command is empty (just ";"), which is error.
,--make V=1--
| GEN /dev/shm/blinux/Makefile
|set -e; ; mkdir -p include/linux/;
[]
|/bin/sh: Syntax error: ";" unexpected
`--
That "silent" juggling with echo is overhead, thus remove it.
--
My (i.e. wrong:) view of the patch. Side effect -- empty line in V=2 garbage output.
mnt/zdev0/linux-2.6/scripts/Kbuild.include renamed from mnt/work/pc/kernel.org/git-repoes/linux-2.6/scripts/Kbuild.include +5 -6
@@ -39,19 +39,18 @@ # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($<) so one has # to specify a valid file as first prerequisite (often the kbuild file) - quiet_chk_filechk = echo ' CHK $@' -silent_chk_filechk = : - quiet_upd_filechk = echo ' UPD $@' -silent_upd_filechk = : +quiet_chk_filechk = ' CHK $@' +quiet_upd_filechk = ' UPD $@' + define filechk $(Q)set -e; \ - $($(quiet)chk_filechk); \ + echo $($(quiet)chk_filechk); \ mkdir -p $(dir $@); \ $(filechk_$(1)) < $< > [email protected]; \ if [ -r $@ ] && cmp -s $@ [email protected]; then \ rm -f [email protected]; \ else \ - $($(quiet)upd_filechk); \ + echo $($(quiet)upd_filechk); \ mv -f [email protected] $@; \ fi endef
Re: shell command is empty, when "silent" (Re: make V=1 broken)
Quoted 16 lines · Oleg Verych
Quoted 11 lines · Sam Ravnborg
make V=1 is broken at the moment.
I do not have possibility to look at it until
in ~20 hours.
So if anyone can help until then...To reproduce:
make defconfig
make V=1Somehow $(quiet) == "", when it should be "
silent_". Thus command is empty (just ";"), which is error.
Quoted 8 lines
,--
make V=1--
| GEN/dev/shm/blinux/Makefile
|set -e; ; mkdir -pinclude/linux/;
[]
|/bin/sh: Syntax error: ";" unexpected
`--That "silent" juggling with
echois overhead, thus remove it.
Hi Oleg.
People has requested to make the build even more silent with
make -s. So when Mike provided a patch is was applied (but unfortunately faulty).
So I fixed it by appended patch.
The right fix would have been to resue echo-cmd but that required a bit more rework.
Sam
From 49af821e4b1c07e756cbc2e389eba9d885912602 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <[email protected]>
Date: Mon, 11 Feb 2008 14:26:26 +0100
Subject: [PATCH] kbuild: fix make V=1
When make -s support were added to filechk to
combination created with make V=1 were not
covered.
Fix it by explicitly cover this case too.
--- scripts/Kbuild.include | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
scripts/Kbuild.include +3 -0
@@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($<) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \
Signature · 1 line
1.5.4.rc3.14.g44397
Re: shell command is empty, when "silent" (Re: make V=1 broken)
Quoted 1 line · Sam Ravnborg
On Mon, Feb 11, 2008 at 03:46:40AM +0100, Oleg Verych wrote:
[]
Quoted 9 lines
Quoted 8 lines
,--
make V=1--
| GEN/dev/shm/blinux/Makefile
|set -e; ; mkdir -pinclude/linux/;
[]
|/bin/sh: Syntax error: ";" unexpected
`--That "silent" juggling with
echois overhead, thus remove it.
Quoted 7 lines
Hi Oleg.
People has requested to make the build even more silent with
make -s. So when Mike provided a patch is was applied (but unfortunately faulty).So I fixed it by appended patch.
The right fix would have been to resue echo-cmd but that required a bit more rework.
[]
Memory is cheap, efficiency is uselsess.
Funny, that *debug* output didn't give a clue for quite some people.
Aah, why do i care?
Quoted 14 lines
# to specify a valid file as first prerequisite (often the kbuild file)
scripts/Kbuild.include +3
-0+ chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \Signature · 1 line
1.5.4.rc3.14.g44397