Skip to contentSkip to conversation

drivers/memstick/host/tifm_ms.c breakage

PATCH In review Al Viro 2 participants 3 messages Feb 13, 2008

Subsystems (2)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 drivers/memstick/host/tifm_ms.c breakage

readl(sock + ...) that should've been readl(sock->addr + ...)

---

drivers/memstick/host/tifm_ms.c +1 -1
index f55b71a..4fb2421 100644
@@ -282,7 +282,7 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host)
 
 			writel(TIFM_MS_SYS_LATCH
 			       | readl(sock->addr + SOCK_MS_SYSTEM),
-			       sock + SOCK_MS_SYSTEM);
+			       sock->addr + SOCK_MS_SYSTEM);
 			writel(0, sock->addr + SOCK_MS_DATA);
 			dev_dbg(&sock->dev, "writing %x\n", 0);
 
author
#1 lore raw
Quoted 1 line · Al Viro

readl(sock + ...) that should've been readl(sock->addr + ...)

s/readl(/writel(..., / in the changelog message...