Skip to contentSkip to conversation

x86_64 allmodconfig

DISCUSSION Mauro Carvalho Chehab 2 participants 2 messages Feb 14, 2008 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mauro Carvalho Chehab

author
#1 lore raw
Quoted 6 lines · On Wed, 13 Feb 2008 14:32:35 -0800 Andrew Morton <[email protected]>…

In file included from drivers/media/video/meye.h:261,
from drivers/media/video/meye.c:41:
include/linux/meye.h:61:1: warning: "V4L2_CID_SHARPNESS" redefined
In file included from include/linux/videodev.h:15,
from drivers/media/video/meye.c:32:
include/linux/videodev2.h:879:1: warning: this is the location of the previous definition

Thanks, I'm ware about it.

We should have a patch probably tomorrow to fix the
name conflicts. The weird is the the two controls have the same meaning, but probably with different value ranges. So, we shold take some care to handle this one.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#2 lore raw
Quoted 10 lines · Mauro Carvalho Chehab
Quoted 6 lines · On Wed, 13 Feb 2008 14:32:35 -0800 Andrew Morton <[email protected]>…

In file included from drivers/media/video/meye.h:261,
from drivers/media/video/meye.c:41:
include/linux/meye.h:61:1: warning: "V4L2_CID_SHARPNESS" redefined
In file included from include/linux/videodev.h:15,
from drivers/media/video/meye.c:32:
include/linux/videodev2.h:879:1: warning: this is the location of the previous definition

Quoted 6 lines

Thanks, I'm ware about it.

We should have a patch probably tomorrow to fix the
name conflicts. The weird is the the two controls have the same meaning, but probably with different value ranges. So, we shold take some care to handle this one.

The current range on meye's sharpness control is 0-63 with 32 as default. This is fine since the new v4l2-spec says the SHARPNESS control's range is implementation specific.

The question is whether a 0 value disables the sharpness filter and if increasing numbers increase the sharpness filter.

We can probably assume it does but, I will CC the owners of the driver and find out. Stelian? Tridge?

Thanks,

Brandon

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list