Bug in dependency checking
Hi,
there is a bug in the dependency checking. If we modify a source file, and then rebuild U-Boot, it will not generate a new git commit ID in the version string.
Can somebody please help me with this? Thanks in advance.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de God runs electromagnetics by wave theory on Monday, Wednesday, and Friday, and the Devil runs them by quantum theory on Tuesday, Thurs- day, and Saturday. -- William Bragg
Quoted 7 lines · Wolfgang Denk
Hi,
there is a bug in the dependency checking. If we modify a source file, and then rebuild U-Boot, it will not generate a new git commit ID in the version string.
Can somebody please help me with this? Thanks in advance.
What about simply adding VERSION_FILE to the PHONY targets ? in this way the script /tools/setlocalversion is always called and version_autogenerated.h is replaced only if the script find a modified source file.
Makefile +1 -1
@@ -244,7 +244,7 @@ LIBS += libfdt/libfdt.a LIBS += api/libapi.a LIBS := $(addprefix $(obj),$(LIBS)) -.PHONY : $(LIBS) +.PHONY : $(LIBS) $(VERSION_FILE)
Regards,
stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
Quoted 5 lines · In message <[email protected]> you wrote:
What about simply adding
VERSION_FILEto the PHONY targets ? in this way the script /tools/setlocalversion is always called andversion_autogenerated.his replaced only if the script find a modified source file.
Looks good to me, thanks.
Can you please send your Signed-off-by: for this patch?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Question: How does one get fresh air into a Russian church? Answer: One clicks on an icon, and a window opens!