git-nfsd on ia64
Subsystems (2)
Cunningly, current git-nfsd causes this, with ia64 allmodconfig:
.config:3397:warning: trying to assign nonexistent symbol NFSD_TCP In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:297:1: warning: "elf_check_arch" redefined In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:19:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:302:1: warning: "ELF_CLASS" redefined
In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:24:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:304:1: warning: "ELF_ARCH" redefined
In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:26:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:318:1: warning: "ELF_EXEC_PAGESIZE" redefined In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:34:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:327:1: warning: "ELF_ET_DYN_BASE" redefined In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:43:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:330:1: warning: "ELF_PLAT_INIT" redefined In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:140:1: warning: this is the location of the previous definition In file included from arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:342:1: warning: "SET_PERSONALITY" redefined In file included from include/linux/elf.h:7,
from include/linux/module.h:14,
from include/linux/textsearch.h:9,
from include/linux/skbuff.h:26,
from include/linux/icmpv6.h:79,
from include/linux/ipv6.h:197,
from include/net/ipv6.h:18,
from include/linux/sunrpc/svcauth.h:18,
from include/linux/sunrpc/svc.h:18,
from arch/ia64/ia32/sys_ia32.c:37:include/asm/elf.h:180:1: warning: this is the location of the previous definition
I bet you didn't expect that.
Our header files suck.
Quoted 15 lines · On Fri, 15 Feb 2008 22:39:43 -0800 Andrew Morton <[email protected]>…
Cunningly, current git-nfsd causes this, with ia64 allmodconfig:
.config:3397:warning: trying to assign nonexistent symbol
NFSD_TCPIn file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:297:1: warning: "elf_check_arch" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
Quoted 1 line
include/asm/elf.h:19:1: warning: this is the location of the previous definition
Easy fix:
include/linux/sunrpc/svcauth.h renamed from include/linux/sunrpc/svcauth.h~git-nfsd-fix +1 -1
@@ -15,7 +15,6 @@#include <linux/sunrpc/msg_prot.h> #include <linux/sunrpc/cache.h> #include <linux/hash.h> -#include <net/ipv6.h> #define SVC_CRED_NGROUPS 32struct svc_cred {
@@ -25,6 +24,7 @@ struct svc_cred { };struct svc_rqst ;/* forward decl */ +struct in6_addr ;/* Authentication is done in the context of a domain. *
_
This should have been done in the first place, IMO. Avoid header file dependencies, faster compile, avoid crap like the above.
J. Bruce Fields
AppliedQuoted 2 lines · Andrew Morton
Cunningly, current git-nfsd causes this, with ia64 allmodconfig:
I've applied your fix, thanks!
By the way:
Quoted 2 lines
.config:3397:warning: trying to assign nonexistent symbol
NFSD_TCP
Should I be removing all references to NFSD_TCP in the patch that removes NFSD_TCP? That would mean touching 90 config files under arch.
--b.
Quoted 96 lines
In file included from
arch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:297:1: warning: "elf_check_arch" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:19:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:302:1: warning: "ELF_CLASS" redefined
In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:24:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:304:1: warning: "ELF_ARCH" redefined
In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:26:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:318:1: warning: "ELF_EXEC_PAGESIZE" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:34:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:327:1: warning: "ELF_ET_DYN_BASE" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:43:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:330:1: warning: "ELF_PLAT_INIT" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:140:1: warning: this is the location of the previous definition In file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:342:1: warning: "SET_PERSONALITY" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:
include/asm/elf.h:180:1: warning: this is the location of the previous definitionI bet you didn't expect that.
Our header files suck.
Quoted 5 lines · On Sat, 16 Feb 2008 20:12:06 -0500 "J. Bruce Fields" <[email protected]>…
Quoted 2 lines
.config:3397:warning: trying to assign nonexistent symbol
NFSD_TCPShould I be removing all references to
NFSD_TCPin the patch that removesNFSD_TCP? That would mean touching 90 config files under arch.
Nope. They will slowly disappear over time as maintainers refresh their defconfigs.
Quoted 42 lines · Andrew Morton
Quoted 15 lines · On Fri, 15 Feb 2008 22:39:43 -0800 Andrew Morton <[email protected]>…
Cunningly, current git-nfsd causes this, with ia64 allmodconfig:
.config:3397:warning: trying to assign nonexistent symbol
NFSD_TCPIn file included fromarch/ia64/ia32/sys_ia32.c:59:arch/ia64/ia32/ia32priv.h:297:1: warning: "elf_check_arch" redefined In file included frominclude/linux/elf.h:7,from include/linux/module.h:14, from include/linux/textsearch.h:9, from include/linux/skbuff.h:26, from include/linux/icmpv6.h:79, from include/linux/ipv6.h:197, from include/net/ipv6.h:18, from include/linux/sunrpc/svcauth.h:18, from include/linux/sunrpc/svc.h:18, from arch/ia64/ia32/sys_ia32.c:37:Quoted 1 line
include/asm/elf.h:19:1: warning: this is the location of the previous definitionEasy fix:
include/linux/sunrpc/svcauth.h renamed from include/linux/sunrpc/svcauth.h~git-nfsd-fix +1
-1@@ -15,7 +15,6 @@#include <linux/sunrpc/msg_prot.h> #include <linux/sunrpc/cache.h> #include <linux/hash.h> -#include <net/ipv6.h> #define SVC_CRED_NGROUPS 32struct svc_cred {@@ -25,6 +24,7 @@ struct svc_cred { };struct svc_rqst ;/* forward decl */ +struct in6_addr ;/* Authentication is done in the context of a domain. * _
Quoted 2 lines
This should have been done in the first place, IMO. Avoid header file dependencies, faster compile, avoid crap like the above.
OK. So as a general rule, we should skip the include any time when a few structure declarations would suffice?
Hm. It also seems wrong that sys_ia32.c would need to include so many nfsd/sunrpc headers. It looks like that should be easy to fix with a better organization of the nfsd headers--I'll do that, assuming it's considered worthwhile....
--b.
Quoted 5 lines · J. Bruce Fields
Quoted 2 lines
This should have been done in the first place, IMO. Avoid header file dependencies, faster compile, avoid crap like the above.
OK. So as a general rule, we should skip the include any time when a few structure declarations would suffice?
Yes. Unessecary includes should always be avoided, and forward declarations are a nice way to avoid includes.
Quoted 4 lines
Hm. It also seems wrong that
sys_ia32.cwould need to include so many nfsd/sunrpc headers. It looks like that should be easy to fix with a better organization of the nfsd headers--I'll do that, assuming it's considered worthwhile....
Why does it need to include either of these at all? There's nothing nfs-specific in that file.
Quoted 10 lines · Andrew Morton
Quoted 5 lines · On Sat, 16 Feb 2008 20:12:06 -0500 "J. Bruce Fields" <[email protected]>…
Quoted 2 lines
.config:3397:warning: trying to assign nonexistent symbol
NFSD_TCPShould I be removing all references to
NFSD_TCPin the patch that removesNFSD_TCP? That would mean touching 90 config files under arch.Nope. They will slowly disappear over time as maintainers refresh their defconfigs.
That implies maintainers actually maintaining it. When did we get the last real update (nto just removeing dead options) to the 32bit x86 defconfig?
Quoted 3 lines · Christoph Hellwig
That implies maintainers actually maintaining it. When did we get the last real update (nto just removeing dead options) to the 32bit x86 defconfig?
The last one I recall was in July 2006 when someone set the SUSPEND partition in defconfig and machines without that partition existing would panic on bootup.
Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."