fs/drop_caches.c: make 2 functions static
PATCH 1/1 fs/drop_caches.c: make 2 functions static
This patch makes the following needlessly global functions static:
- drop_pagecache()
- drop_slab()
---
fs/drop_caches.c | 4 ++-- include/linux/mm.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-)
32191754eb7aed31406850a082565bc428268a08 diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 59375ef..e2c6b65 100644
fs/drop_caches.c +2 -2
@@ -25,7 +25,7 @@ static void drop_pagecache_sb(struct super_block *sb)spin_unlock (&inode_lock); } -void drop_pagecache (void ) +static void drop_pagecache (void ) {struct super_block *sb;
@@ -45,7 +45,7 @@ restart:spin_unlock (&sb_lock); } -void drop_slab (void ) +static void drop_slab (void ) {int nr_objects;
include/linux/mm.h +0 -2
@@ -1192,8 +1192,6 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, struct file *, void __user *, size_t *, loff_t *);unsigned long shrink_slab (unsigned long scanned,gfp_t gfp_mask,unsigned long lru_pages); -void drop_pagecache (void ); -void drop_slab (void );#ifndef CONFIG_MMU #define randomize_va_space 0
Andrew Morton
maintainerQuoted 26 lines · On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <[email protected]> wrote:
This patch makes the following needlessly global functions static:
-drop_pagecache()
-drop_slab()Signed-off-by Adrian Bunk <[email protected]>---
fs/drop_caches.c | 4 ++-- include/linux/mm.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-)
32191754eb7aed31406850a082565bc428268a08diff --gita/fs/drop_caches.cb/fs/drop_caches.cindex 59375ef..e2c6b65 100644fs/drop_caches.c +1
-1@@ -25,7 +25,7 @@ static void drop_pagecache_sb(struct super_block *sb)spin_unlock (&inode_lock); } -void drop_pagecache (void ) +static void drop_pagecache (void ) {struct super_block *sb;
fs/drop_caches.c restart: · line 51
Quoted 8 lines
fs/drop_caches.c +1
-1@@ -45,7 +45,7 @@ restart:spin_unlock (&sb_lock); } -void drop_slab (void ) +static void drop_slab (void ) {int nr_objects;
This was originally done because Neil said that he planned to use these in nfsd. I guess that didn't happen, and an additional patch would be needed here anyway to do the module exports. So.... zap.
Neil Brown
Acked-byQuoted 7 lines · On Monday February 18, [email protected] wrote:
Quoted 5 lines · On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <[email protected]> wrote:
This patch makes the following needlessly global functions static:
-drop_pagecache()
-drop_slab()Signed-off-by Adrian Bunk <[email protected]>
..
Quoted 4 lines
This was originally done because Neil said that he planned to use these in nfsd. I guess that didn't happen, and an additional patch would be needed here anyway to do the module exports. So.... zap.
Did I? I wonder why. Neither my memory or my mail archive gives me any hints, so I suspect it must have just been a passing fancy that resolved into a really dumb idea (as so many passing fancies do).
Hmmm... I guess that should really be
;-)
NeilBrown