Skip to contentSkip to conversation

i2c: Storage class should be before const qualifier

PATCH Applied Tobias Klauser 2 participants 2 messages Feb 17, 2008 1 message not in the archive

Subsystems (2)
I2C subsystem host drivers I2C
lore
Share & tools
lore

Tobias Klauser

author
#0 lore raw

PATCH 1/1 i2c: Storage class should be before const qualifier

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature.

Signed-off-by Tobias Klauser <[email protected]>
---
 drivers/i2c/busses/i2c-pmcmsp.c |    4 ++--
 include/linux/i2c.h             |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-pmcmsp.c +2 -2
index be99c02..b03af56 100644
@@ -122,7 +122,7 @@ struct pmcmsptwi_data {
 };
 
 /* The default settings */
-const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
+static const struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
 	.standard = {
 		.filter	= 0x3,
 		.clock	= 0x1f,

@@ -133,7 +133,7 @@ const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
 	},
 };
 
-const static struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
+static const struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
 	.arbf		= 0x03,
 	.nak		= 0x03,
 	.add10		= 0x00,
include/linux/i2c.h +1 -1
index 76014f8..2d1c608 100644
@@ -598,7 +598,7 @@ I2C_CLIENT_MODULE_PARM(probe, "List of adapter,address pairs to scan "	\
 		       "additionally");					\
 I2C_CLIENT_MODULE_PARM(ignore, "List of adapter,address pairs not to "	\
 		       "scan");						\
-const static struct i2c_client_address_data addr_data = {		\
+static const struct i2c_client_address_data addr_data = {		\
 	.normal_i2c	= normal_i2c,					\
 	.probe		= probe,					\
 	.ignore		= ignore,					\
Signature · 7 lines
1.5.4.1


_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw

Hi Tobias,

Quoted 39 lines · Tobias Klauser

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature.

Signed-off-by Tobias Klauser <[email protected]>
---
 drivers/i2c/busses/i2c-pmcmsp.c |    4 ++--
 include/linux/i2c.h             |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-pmcmsp.c +2 -2
index be99c02..b03af56 100644
@@ -122,7 +122,7 @@ struct pmcmsptwi_data {
 };
 
 /* The default settings */
-const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
+static const struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
 	.standard = {
 		.filter	= 0x3,
 		.clock	= 0x1f,

@@ -133,7 +133,7 @@ const static struct pmcmsptwi_clockcfg pmcmsptwi_defclockcfg = {
 	},
 };
 
-const static struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
+static const struct pmcmsptwi_cfg pmcmsptwi_defcfg = {
 	.arbf		= 0x03,
 	.nak		= 0x03,
 	.add10		= 0x00,
include/linux/i2c.h +0 -0
index 76014f8..2d1c608 100644

include/linux/i2c.h I2C_CLIENT_MODULE_PARM(probe, "List of adapter,address pairs to scan " \ · line 604

Quoted 8 lines
include/linux/i2c.h +1 -1
@@ -598,7 +598,7 @@ I2C_CLIENT_MODULE_PARM(probe, "List of adapter,address pairs to scan "	\
 		       "additionally");					\
 I2C_CLIENT_MODULE_PARM(ignore, "List of adapter,address pairs not to "	\
 		       "scan");						\
-const static struct i2c_client_address_data addr_data = {		\
+static const struct i2c_client_address_data addr_data = {		\
 	.normal_i2c	= normal_i2c,					\
 	.probe		= probe,					\
 	.ignore		= ignore,					\

Applied, thanks.

Signature · 6 lines
Jean Delvare

_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c