arch/x86/kernel/acpi/sleep_32.c not compiled ?

DISCUSSION Thomas Petazzoni 3 participants 9 messages Feb 19, 2008

Share & tools

Thomas Petazzoni

author

2008-02-19 15:59 UTC #0 lore raw

Hi,

Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:

obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o

ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif

Sincerly,

Thomas

Signature · 4 lines

Thomas Petazzoni, [email protected], http://thomas.enix.org
Jabber, [email protected]
Toulibre, http://www.toulibre.org - APRIL, http://www.april.org
Fingerprint : 0BE1 4CF3 CEA4 AC9D CC6E  1624 F653 CB30 98D3 F7A7

Rafael J. Wysocki

2008-02-19 21:02 UTC #1 lore raw

Quoted 1 line · Thomas Petazzoni

Hi,

Hi,

Quoted 10 lines

Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif

No, the file is not build now.

Pavel, is this file really necessary?

Rafael

Rafael J. Wysocki

2008-02-19 21:04 UTC #2 lore raw

In reply to Thomas Petazzoni

Quoted 1 line · Thomas Petazzoni

Hi,

Hi,

Quoted 10 lines

Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif

No, the file is not build now.

Pavel, is this file really necessary?

Rafael

Pavel Machek

2008-02-19 22:26 UTC #3 lore raw

Quoted 12 lines · Rafael J. Wysocki

Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 7 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o

Quoted 7 lines

Quoted 3 lines
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif
No, the file is not build now.
Pavel, is this file really necessary?

sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with just one entry ;-). Remove it. If Mirek Spousta (probably last remaining owner of whitelisted toshiba, he got it from me ;-) complains, I'll give him better machine or something.
Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Rafael J. Wysocki

2008-02-19 23:41 UTC #4 lore raw

Quoted 17 lines · Pavel Machek

Quoted 16 lines · Rafael J. Wysocki
Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 10 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif

Quoted 8 lines

Quoted 3 lines
No, the file is not build now.
Pavel, is this file really necessary?
sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with just one entry ;-). Remove it. If Mirek Spousta (probably last remaining owner of whitelisted toshiba, he got it from me ;-) complains, I'll give him better machine or something.

Well, then perhaps we also should remove the S1 quirk for the same box from drivers/acpi/sleep/main.c ?

Alternatively, put them both into the same file and simplify things (in which case I'd vote for drivers/acpi/sleep/main.c)?

Rafael

Rafael J. Wysocki

2008-02-19 23:43 UTC #5 lore raw

In reply to Pavel Machek

Quoted 17 lines · Pavel Machek

Quoted 16 lines · Rafael J. Wysocki
Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 10 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif

Quoted 8 lines

Quoted 3 lines
No, the file is not build now.
Pavel, is this file really necessary?
sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with just one entry ;-). Remove it. If Mirek Spousta (probably last remaining owner of whitelisted toshiba, he got it from me ;-) complains, I'll give him better machine or something.

Well, then perhaps we also should remove the S1 quirk for the same box from drivers/acpi/sleep/main.c ?

Alternatively, put them both into the same file and simplify things (in which case I'd vote for drivers/acpi/sleep/main.c)?

Rafael

Pavel Machek

2008-02-19 23:44 UTC #6 lore raw

Quoted 22 lines · Rafael J. Wysocki

Quoted 21 lines · Pavel Machek
Quoted 19 lines · Rafael J. Wysocki
Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 10 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif
No, the file is not build now.
Pavel, is this file really necessary?

Quoted 7 lines

Quoted 4 lines
sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with just one entry ;-). Remove it. If Mirek Spousta (probably last remaining owner of whitelisted toshiba, he got it from me ;-) complains, I'll give him better machine or something.
Well, then perhaps we also should remove the S1 quirk for the same box from drivers/acpi/sleep/main.c ?

Yes we probably can do that.
Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Pavel Machek

2008-02-19 23:44 UTC #7 lore raw

In reply to Rafael J. Wysocki

Quoted 22 lines · Rafael J. Wysocki

Quoted 21 lines · Pavel Machek
Quoted 19 lines · Rafael J. Wysocki
Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 10 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif
No, the file is not build now.
Pavel, is this file really necessary?

Quoted 7 lines

Quoted 4 lines
sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with just one entry ;-). Remove it. If Mirek Spousta (probably last remaining owner of whitelisted toshiba, he got it from me ;-) complains, I'll give him better machine or something.
Well, then perhaps we also should remove the S1 quirk for the same box from drivers/acpi/sleep/main.c ?

Yes we probably can do that.
Pavel

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Pavel Machek

2008-02-19 22:26 UTC #8 lore raw

In reply to Rafael J. Wysocki

Quoted 12 lines · Rafael J. Wysocki

Quoted 1 line · Thomas Petazzoni
Hi,
Hi,
Quoted 7 lines
Maybe I'm missing something completely obvious, but I don't see where the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
obj-$(CONFIG_ACPI) += boot.o
obj-$(CONFIG_ACPI_SLEEP) += sleep.o wakeup_$(BITS).o

Quoted 7 lines

Quoted 3 lines
ifneq ($(CONFIG_ACPI_PROCESSOR),)
obj-y += cstate.o processor.o
endif
No, the file is not build now.
Pavel, is this file really necessary?

Signature · 2 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html