Skip to contentSkip to conversation

x86: Coding style fixes to arch/x86/mach-generic/probe.c

PATCH Ingo Molnar 2 participants 2 messages Feb 20, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20080219235717.0a4c69e2@paolo-desktop

#1 lore raw

Review

Quoted 4 lines · Paolo Ciarrocchi
(quoted diff) +2 -2
-	for (i = 0; apic_probe[i]; ++i) { 
-		if (apic_probe[i]->mps_oem_check(mpc,oem,productid)) { 
+	for (i = 0; apic_probe[i]; ++i) {
+		if (apic_probe[i]->mps_oem_check(mpc, i oem, productid)) {

you typoed that one. Please build-test files you change.

Ingo

#2 lore raw
Quoted 9 lines · Ingo Molnar

Review

Quoted 4 lines · Paolo Ciarrocchi
(quoted diff) +2 -2
-     for (i = 0; apic_probe[i]; ++i) {
-             if (apic_probe[i]->mps_oem_check(mpc,oem,productid)) {
+     for (i = 0; apic_probe[i]; ++i) {
+             if (apic_probe[i]->mps_oem_check(mpc, i oem, productid)) {

you typoed that one. Please build-test files you change.

Yup, sorry about that!
Won't happen in the future.

Ciao,

Signature · 2 lines
Paolo
http://paolo.ciarrocchi.googlepages.com/