Skip to contentSkip to conversation

acpi_wakeup_address in .data vs .bss (Fwd: [PATCH 18/20] x86: Coding Style fixes to arch/x86/kernel/acpi/sleep.c)

DISCUSSION Pavel Machek 1 participant 1 message Feb 23, 2008 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 2 lines · Len Brown

was there any particular reason we forced acpi_wakeup_address into .data instead of into .bss?

In my tree it is in .bss already... ...I think that was done during "wakeup-to-.c" move.

So this patch is okay.

But you actually might want to drop this, preventing merge conflict...
Pavel

Quoted 30 lines

---------- Forwarded Message ----------

Subject: [PATCH 18/20] x86: Coding Style fixes to arch/x86/kernel/acpi/sleep.c
Date: Friday 22 February 2008 17:11
From: Paolo Ciarrocchi <[email protected]>
To: hpa <[email protected]>, Ingo Molnar <[email protected]>, tglx <[email protected]>
Cc: Linux Kernel <[email protected]>

File is now error free.
Compile tested.

---
 arch/x86/kernel/acpi/sleep.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/acpi/sleep.c +1 -1
index 6bc815c..dd78326 100644
@@ -13,7 +13,7 @@
 #include <asm/smp.h>
 
 /* address in low memory of the wakeup routine. */
-unsigned long acpi_wakeup_address = 0;
+unsigned long acpi_wakeup_address;
 unsigned long acpi_realmode_flags;
 extern char wakeup_start, wakeup_end;
 
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html