Skip to contentSkip to conversation

gfs2: fix file_system_type leak on gfs2meta mount

PATCH In review Christoph Hellwig 2 participants 2 messages Feb 25, 2008 – Feb 26, 2008 GFS2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: fix file_system_type leak on gfs2meta mount

get_gfs2_sb does a get_fs_type without doing a put_filesystem and thus leaking a file_system_type reference everytime it's called.

Just use gfs2_fs_type directly instead of doing the lookup and thus fix the problem.

fs/gfs2/ops_fstype.c +1 -3
Index: linux-2.6/fs/gfs2/ops_fstype.c
===================================================================
@@ -874,7 +874,6 @@ static struct super_block* get_gfs2_sb(c
 {
 	struct kstat stat;
 	struct nameidata nd;
-	struct file_system_type *fstype;
 	struct super_block *sb = NULL, *s;
 	int error;
 
@@ -886,8 +885,7 @@ static struct super_block* get_gfs2_sb(c
 	}
 	error = vfs_getattr(nd.path.mnt, nd.path.dentry, &stat);
 
-	fstype = get_fs_type("gfs2");
-	list_for_each_entry(s, &fstype->fs_supers, s_instances) {
+	list_for_each_entry(s, &gfs2_fs_type.fs_supers, s_instances) {
 		if ((S_ISBLK(stat.mode) && s->s_dev == stat.rdev) ||
 		    (S_ISDIR(stat.mode) &&
 		     s == nd.path.dentry->d_inode->i_sb)) {
#1 lore raw

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 31 lines · Christoph Hellwig

get_gfs2_sb does a get_fs_type without doing a put_filesystem and thus leaking a file_system_type reference everytime it's called.

Just use gfs2_fs_type directly instead of doing the lookup and thus fix the problem.

Index: linux-2.6/fs/gfs2/ops_fstype.c
===================================================================

fs/gfs2/ops_fstype.c +1 -3
@@ -874,7 +874,6 @@ static struct super_block* get_gfs2_sb(c
 {
 	struct kstat stat;
 	struct nameidata nd;
-	struct file_system_type *fstype;
 	struct super_block *sb = NULL, *s;
 	int error;
 
@@ -886,8 +885,7 @@ static struct super_block* get_gfs2_sb(c
 	}
 	error = vfs_getattr(nd.path.mnt, nd.path.dentry, &stat);
 
-	fstype = get_fs_type("gfs2");
-	list_for_each_entry(s, &fstype->fs_supers, s_instances) {
+	list_for_each_entry(s, &gfs2_fs_type.fs_supers, s_instances) {
 		if ((S_ISBLK(stat.mode) && s->s_dev == stat.rdev) ||
 		    (S_ISDIR(stat.mode) &&
 		     s == nd.path.dentry->d_inode->i_sb)) {