sysfs: duplicate filename '74' can not be created
[Cc'ing /sys/kernel/uids guys]
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1
I see only one suspicious place: KOBJ_ADD is sent even if sysfs file creation failed and kobject is happily removed. But this almost certainly separate bug.
You can try this debugging patch. Post several first consecutive messages. [crosses fingers]
kernel/user.c +10 -1
@@ -179,8 +179,11 @@ static int user_kobject_create(struct user_struct *up) goto done; error =sysfs_create_file (kobj, &up->user_attr.attr); -if (error) +if (error) { +printk ("%s: %p->uid = %d\n" , __func__, up, up->uid); +WARN_ON (1 );kobject_del (kobj); + }kobject_uevent (kobj,KOBJ_ADD );
@@ -363,6 +366,7 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid) }if (sched_create_user (new) <0 ) { +WARN_ON (1 );key_put (new->uid_keyring);key_put (new->session_keyring);kmem_cache_free (uid_cachep, new);
@@ -371,6 +375,7 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid) }if (user_kobject_create (new)) { +WARN_ON (1 );sched_destroy_user (new);key_put (new->uid_keyring);key_put (new->session_keyring);
@@ -386,6 +391,10 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid)spin_lock_irq (&uidhash_lock); up =uid_hash_find (uid, hashent);if (up) { +#ifdef CONFIG_FAIR_USER_SCHED +printk ("%s: %p->uid = %d\n" , __func__, up, up->uid); +WARN_ON (1 ); +#endif /* This case is not possible when CONFIG_FAIR_USER_SCHED * is defined, since we serialize alloc_uid() using * uids_mutex. Hence no need to call
kernel/user_namespace.c +2 -0
@@ -32,6 +32,8 @@ static struct user_namespace *clone_user_ns(struct user_namespace *old_ns)struct user_struct *new_user;int n; +printk ("%s: ENTER\n" , __func__); + ns =kmalloc (sizeof (struct user_namespace ),GFP_KERNEL );if (!ns)return ERR_PTR (-ENOMEM );
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys]
[Also adding gregkh to the cc :)]
Quoted 68 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1I see only one suspicious place:
KOBJ_ADDis sent even if sysfs file creation failed and kobject is happily removed. But this almost certainly separate bug.You can try this debugging patch. Post several first consecutive messages. [crosses fingers]
kernel/user.c +10
-1@@ -179,8 +179,11 @@ static int user_kobject_create(struct user_struct *up) goto done; error =sysfs_create_file (kobj, &up->user_attr.attr); -if (error) +if (error) { +printk ("%s: %p->uid = %d\n" , __func__, up, up->uid); +WARN_ON (1 );kobject_del (kobj); + }kobject_uevent (kobj,KOBJ_ADD );@@ -363,6 +366,7 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid) }if (sched_create_user (new) <0 ) { +WARN_ON (1 );key_put (new->uid_keyring);key_put (new->session_keyring);kmem_cache_free (uid_cachep, new);@@ -371,6 +375,7 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid) }if (user_kobject_create (new)) { +WARN_ON (1 );sched_destroy_user (new);key_put (new->uid_keyring);key_put (new->session_keyring);@@ -386,6 +391,10 @@ struct user_struct * alloc_uid(struct user_namespace *ns, uid_t uid)spin_lock_irq (&uidhash_lock); up =uid_hash_find (uid, hashent);if (up) { +#ifdef CONFIG_FAIR_USER_SCHED +printk ("%s: %p->uid = %d\n" , __func__, up, up->uid); +WARN_ON (1 ); +#endif /* This case is not possible when CONFIG_FAIR_USER_SCHED * is defined, since we serialize alloc_uid() using * uids_mutex. Hence no need to call kernel/user_namespace.c +2
-0@@ -32,6 +32,8 @@ static struct user_namespace *clone_user_ns(struct user_namespace *old_ns)struct user_struct *new_user;int n; +printk ("%s: ENTER\n" , __func__); + ns =kmalloc (sizeof (struct user_namespace ),GFP_KERNEL );if (!ns)return ERR_PTR (-ENOMEM );
Signature · 2 lines
regards, Dhaval
Quoted 9 lines · Dhaval Giani
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys][Also adding gregkh to the cc :)]
Quoted 3 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1
What kernel version is this? 2.6.24 had lots of "issues" with the uids code, I'm amazed it worked at all :)
2.6.25-rc should have this all fixed up, if not, please let me know.
thanks,
greg k-h
Quoted 5 lines · Greg KH
Quoted 4 lines · Dhaval Giani
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys]
Quoted 9 lines
Quoted 5 lines
[Also adding gregkh to the cc :)]
Quoted 3 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1What kernel version is this? 2.6.24 had lots of "issues" with the uids code, I'm amazed it worked at all :)
:). Seems to be a stable series kernel (2.6.24.3). Can you please tell me some of the issues, so that I can try to go fix it up.
thanks,
Signature · 2 lines
regards, Dhaval
Quoted 12 lines · Dhaval Giani
Quoted 11 lines · Greg KH
Quoted 9 lines · Dhaval Giani
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys][Also adding gregkh to the cc :)]
Quoted 3 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1
Quoted 6 lines
Quoted 3 lines
What kernel version is this? 2.6.24 had lots of "issues" with the uids code, I'm amazed it worked at all :)
:). Seems to be a stable series kernel (2.6.24.3). Can you please tell me some of the issues, so that I can try to go fix it up.
Ick, there were a lot of them. Take a look at the changes to kernel/user.c (I think that was the file). A lot of the work was reworking it due to the kobject changes, but at the same time lots of code was fixed.
It is a harmless warning, everything should still work properly, right?
thanks,
greg k-h
Quoted 20 lines · Greg KH
Quoted 12 lines · Dhaval Giani
Quoted 11 lines · Greg KH
Quoted 9 lines · Dhaval Giani
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys][Also adding gregkh to the cc :)]
Quoted 3 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1Quoted 6 lines
Quoted 3 lines
What kernel version is this? 2.6.24 had lots of "issues" with the uids code, I'm amazed it worked at all :)
:). Seems to be a stable series kernel (2.6.24.3). Can you please tell me some of the issues, so that I can try to go fix it up.
Quoted 6 lines
Ick, there were a lot of them. Take a look at the changes to
kernel/user.c(I think that was the file). A lot of the work was reworking it due to the kobject changes, but at the same time lots of code was fixed.It is a harmless warning, everything should still work properly, right?
The whole existence of uids_mutex should guarantee that duplicate name can't happen, and that logic with async kobject removal is still in place. And there was an oops afterwards:
http://marc.info/?l=linux-kernel&m=120455796407423&w=2
Quoted 6 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys]Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1
Quoted 9 lines
I see only one suspicious place:
KOBJ_ADDis sent even if sysfs file creation failed and kobject is happily removed. But this almost certainly separate bug.You can try this debugging patch. Post several first consecutive messages. [crosses fingers]
Applied the patch and this time it oopsed immediatly. I just got one:
Mar 7 07:09:04 helena kernel: general protection fault: 0000 [1] SMP Mar 7 07:09:04 helena kernel: CPU 3 Mar 7 07:09:04 helena kernel: Modules linked in: lm85 hwmon_vid i2c_amd756_s4882 bonding nf_conntrack_ftp nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack xt_tcpudp iptable_filter ip_tables x_tables binfmt_misc video output ac floppy nvram ohci_hcd k8temp i2c_amd756 i2c_core button usbcore Mar 7 07:09:04 helena kernel: Pid: 2983, comm: modprobe Not tainted 2.6.24.3-alexey #3 Mar 7 07:09:04 helena kernel: RIP: 0010:[<ffffffff8027931d>] [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP: 0018:ffff81017d571de8 EFLAGS: 00010046 Mar 7 07:09:04 helena kernel: RAX: 0000000000000000 RBX: 00000000000080d0 RCX: ffffffff8026d2b1 Mar 7 07:09:04 helena kernel: RDX: ffff007265776f70 RSI: 00000000000080d0 RDI: ffffffff80554e38 Mar 7 07:09:04 helena kernel: RBP: ffff810200026800 R08: 00000000005184b0 R09: ffffffff80554e38 Mar 7 07:09:04 helena kernel: R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000286 Mar 7 07:09:04 helena kernel: R13: 00000000ffffffff R14: 00000000ffffffff R15: 00000000005184b0 Mar 7 07:09:04 helena kernel: FS: 00002b66d114c6f0(0000) GS:ffff81027e30e300(0000) knlGS:0000000000000000 Mar 7 07:09:04 helena kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b Mar 7 07:09:04 helena kernel: CR2: 0000003254acc030 CR3: 000000017d530000 CR4: 00000000000006e0 Mar 7 07:09:04 helena kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 Mar 7 07:09:04 helena kernel: DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Mar 7 07:09:04 helena kernel: Process modprobe (pid: 2983, threadinfo ffff81017d570000, task ffff81017df3d5c0) Mar 7 07:09:04 helena kernel: Stack: ffff81027d2fb740 ffffc200017e39a8 ffff81027d2fba00 00000000000000d0 Mar 7 07:09:04 helena kernel: ffffc200017e33e8 ffffffff8026d2b1 0000000000000163 ffffc200017e39a8 Mar 7 07:09:04 helena kernel: 0000000000000018 ffffc200017e39a8 0000000000000018 ffffc200017e2f80 Mar 7 07:09:04 helena kernel: Call Trace: Mar 7 07:09:04 helena kernel: [<ffffffff8026d2b1>] __vmalloc_area_node+0x71/0x185 Mar 7 07:09:04 helena kernel: [<ffffffff80248ec0>] sys_init_module+0x94d/0x1872 Mar 7 07:09:04 helena kernel: [<ffffffff8020b61e>] system_call+0x7e/0x83 Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Code: 48 8b 04 c2 48 89 45 00 41 54 9d 31 c0 c1 eb 0f 48 85 d2 0f Mar 7 07:09:04 helena kernel: RIP [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP <ffff81017d571de8> Mar 7 07:09:04 helena kernel: ---[ end trace 82b7eaeeb11c3ab5 ]---
After this the system was no longer reachable. Note, as before it always happens on CPU3.
Holger
Quoted 5 lines · Greg KH
Quoted 4 lines · Dhaval Giani
Quoted 2 lines · Alexey Dobriyan
[Cc'ing
/sys/kernel/uidsguys]
Quoted 9 lines
Quoted 5 lines
[Also adding gregkh to the cc :)]
Quoted 3 lines
Quoted 3 lines
Mar 3 13:50:01 helena kernel: sysfs: duplicate filename '74' can not be created Mar 3 13:50:01 helena kernel: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Mar 3 13:50:01 helena kernel: Pid: 21911, comm: sshd Not tainted 2.6.24.3 #1What kernel version is this? 2.6.24 had lots of "issues" with the uids code, I'm amazed it worked at all :)
If that is so, would it not be better to disable this code in the stable branch, at least don't set it as default? Or maybe mark this as experimental?
Holger
Quoted 51 lines · Holger Kiehl
Quoted 3 lines · Alexey Dobriyan
You can try this debugging patch. Post several first consecutive messages. [crosses fingers]
Applied the patch and this time it oopsed immediatly. I just got one:
Mar 7 07:09:04 helena kernel: general protection fault: 0000 [1] SMP Mar 7 07:09:04 helena kernel: CPU 3 Mar 7 07:09:04 helena kernel: Modules linked in: lm85 hwmon_vid i2c_amd756_s4882 bonding nf_conntrack_ftp nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack xt_tcpudp iptable_filter ip_tables x_tables binfmt_misc video output ac floppy nvram ohci_hcd k8temp i2c_amd756 i2c_core button usbcore Mar 7 07:09:04 helena kernel: Pid: 2983, comm: modprobe Not tainted 2.6.24.3-alexey #3 Mar 7 07:09:04 helena kernel: RIP: 0010:[<ffffffff8027931d>] [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP: 0018:ffff81017d571de8 EFLAGS: 00010046 Mar 7 07:09:04 helena kernel: RAX: 0000000000000000 RBX: 00000000000080d0 RCX: ffffffff8026d2b1 Mar 7 07:09:04 helena kernel: RDX: ffff007265776f70 RSI: 00000000000080d0 RDI: ffffffff80554e38 Mar 7 07:09:04 helena kernel: RBP: ffff810200026800 R08: 00000000005184b0 R09: ffffffff80554e38 Mar 7 07:09:04 helena kernel: R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000286 Mar 7 07:09:04 helena kernel: R13: 00000000ffffffff R14: 00000000ffffffff R15: 00000000005184b0 Mar 7 07:09:04 helena kernel: FS: 00002b66d114c6f0(0000) GS:ffff81027e30e300(0000) knlGS:0000000000000000 Mar 7 07:09:04 helena kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b Mar 7 07:09:04 helena kernel: CR2: 0000003254acc030 CR3: 000000017d530000 CR4: 00000000000006e0 Mar 7 07:09:04 helena kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 Mar 7 07:09:04 helena kernel: DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Mar 7 07:09:04 helena kernel: Process modprobe (pid: 2983, threadinfo ffff81017d570000, task ffff81017df3d5c0) Mar 7 07:09:04 helena kernel: Stack: ffff81027d2fb740 ffffc200017e39a8 ffff81027d2fba00 00000000000000d0 Mar 7 07:09:04 helena kernel: ffffc200017e33e8 ffffffff8026d2b1 0000000000000163 ffffc200017e39a8 Mar 7 07:09:04 helena kernel: 0000000000000018 ffffc200017e39a8 0000000000000018 ffffc200017e2f80 Mar 7 07:09:04 helena kernel: Call Trace: Mar 7 07:09:04 helena kernel: [<ffffffff8026d2b1>] __vmalloc_area_node+0x71/0x185 Mar 7 07:09:04 helena kernel: [<ffffffff80248ec0>] sys_init_module+0x94d/0x1872 Mar 7 07:09:04 helena kernel: [<ffffffff8020b61e>] system_call+0x7e/0x83
Quoted 9 lines
Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Code: 48 8b 04 c2 48 89 45 00 41 54 9d 31 c0 c1 eb 0f 48 85 d2 0f Mar 7 07:09:04 helena kernel: RIP [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP <ffff81017d571de8> Mar 7 07:09:04 helena kernel: ---[ end trace 82b7eaeeb11c3ab5 ]---
This could maybe be not what you are looking for. It oopsed immediatly when lm_sensors was started. I have now disabled lm_sensors and am currently running a second test.
Holger
Quoted 63 lines · Holger Kiehl
Quoted 52 lines · Holger Kiehl
Quoted 3 lines · Alexey Dobriyan
You can try this debugging patch. Post several first consecutive messages. [crosses fingers]
Applied the patch and this time it oopsed immediatly. I just got one:
Mar 7 07:09:04 helena kernel: general protection fault: 0000 [1] SMP Mar 7 07:09:04 helena kernel: CPU 3 Mar 7 07:09:04 helena kernel: Modules linked in: lm85 hwmon_vid i2c_amd756_s4882 bonding nf_conntrack_ftp nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack xt_tcpudp iptable_filter ip_tables x_tables binfmt_misc video output ac floppy nvram ohci_hcd k8temp i2c_amd756 i2c_core button usbcore Mar 7 07:09:04 helena kernel: Pid: 2983, comm: modprobe Not tainted 2.6.24.3-alexey #3 Mar 7 07:09:04 helena kernel: RIP: 0010:[<ffffffff8027931d>] [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP: 0018:ffff81017d571de8 EFLAGS: 00010046 Mar 7 07:09:04 helena kernel: RAX: 0000000000000000 RBX: 00000000000080d0 RCX: ffffffff8026d2b1 Mar 7 07:09:04 helena kernel: RDX: ffff007265776f70 RSI: 00000000000080d0 RDI: ffffffff80554e38 Mar 7 07:09:04 helena kernel: RBP: ffff810200026800 R08: 00000000005184b0 R09: ffffffff80554e38 Mar 7 07:09:04 helena kernel: R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000286 Mar 7 07:09:04 helena kernel: R13: 00000000ffffffff R14: 00000000ffffffff R15: 00000000005184b0 Mar 7 07:09:04 helena kernel: FS: 00002b66d114c6f0(0000) GS:ffff81027e30e300(0000) knlGS:0000000000000000 Mar 7 07:09:04 helena kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b Mar 7 07:09:04 helena kernel: CR2: 0000003254acc030 CR3: 000000017d530000 CR4: 00000000000006e0 Mar 7 07:09:04 helena kernel: DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 Mar 7 07:09:04 helena kernel: DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Mar 7 07:09:04 helena kernel: Process modprobe (pid: 2983, threadinfo ffff81017d570000, task ffff81017df3d5c0) Mar 7 07:09:04 helena kernel: Stack: ffff81027d2fb740 ffffc200017e39a8 ffff81027d2fba00 00000000000000d0 Mar 7 07:09:04 helena kernel: ffffc200017e33e8 ffffffff8026d2b1 0000000000000163 ffffc200017e39a8 Mar 7 07:09:04 helena kernel: 0000000000000018 ffffc200017e39a8 0000000000000018 ffffc200017e2f80 Mar 7 07:09:04 helena kernel: Call Trace: Mar 7 07:09:04 helena kernel: [<ffffffff8026d2b1>] __vmalloc_area_node+0x71/0x185 Mar 7 07:09:04 helena kernel: [<ffffffff80248ec0>] sys_init_module+0x94d/0x1872 Mar 7 07:09:04 helena kernel: [<ffffffff8020b61e>] system_call+0x7e/0x83Quoted 9 lines
Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Mar 7 07:09:04 helena kernel: Code: 48 8b 04 c2 48 89 45 00 41 54 9d 31 c0 c1 eb 0f 48 85 d2 0f Mar 7 07:09:04 helena kernel: RIP [<ffffffff8027931d>] __kmalloc_node+0x95/0xc9 Mar 7 07:09:04 helena kernel: RSP <ffff81017d571de8> Mar 7 07:09:04 helena kernel: ---[ end trace 82b7eaeeb11c3ab5 ]---
Quoted 4 lines
This could maybe be not what you are looking for. It oopsed immediatly when
lm_sensorswas started. I have now disabledlm_sensorsand am currently running a second test.
So far there have been no further oopses, I have gone back to 2.6.23 since this system is now in operational use. The above oops is the only one I was able to get, is this of any use?
Holger