Skip to contentSkip to conversation

send_group_sigqueue: don't take tasklist_lock

PATCH New Oleg Nesterov 1 participant 1 message Mar 6, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 send_group_sigqueue: don't take tasklist_lock

(depends on signals-re-assign-cld_continued-notification-from-the-sender-to-reciever.patch)

handle_stop_signal() was changed, now send_group_sigqueue() doesn't need tasklist_lock.

kernel/signal.c renamed from kernel/signal.c~5_SGS_NO_TASKLIST +1 -2
@@ -1336,7 +1336,6 @@ send_group_sigqueue(int sig, struct sigq
 
 	BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
 
-	read_lock(&tasklist_lock);
 	/* Since it_lock is held, p->sighand cannot be NULL. */
 	spin_lock_irqsave(&p->sighand->siglock, flags);
 
@@ -1345,7 +1344,7 @@ send_group_sigqueue(int sig, struct sigq
 	__group_complete_signal(sig, p);
 
 	spin_unlock_irqrestore(&p->sighand->siglock, flags);
-	read_unlock(&tasklist_lock);
+
 	return ret;
 }