Skip to contentSkip to conversation

ARM: OMAP: Add IDCODE revision to system_rev

RFC/PATCH Tony Lindgren 1 participant 1 message Mar 13, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20080306003550.GA2709@party

#1 lore raw
Quoted 6 lines · Kyungmin Park

In previous kernel there's IDCODE revision. But recently it was removed. I hope it want to add this one to distinguish board revision.

Are there another way to combine Silicon revision with IDCODE one?

Any comments are welcome.

Well this is not done currently for 34xx, and two bits are not enough so we need something better here eventually..

Anyways, pushing today.

Tony

Quoted 20 lines

---

arch/arm/mach-omap2/id.c +3 -0
index a2109c1..dd53ae2 100644
@@ -168,10 +168,13 @@ void __init omap2_check_revision(void)
 	 * system_rev & 0xffff0000 -> Omap type (2420/2422/2423/2430/3430)
 	 * system_rev & 0x0000f000 -> Silicon revision (ES1, ES2 )
 	 * system_rev & 0x00000700 -> Device Type ( EMU/HS/GP/BAD )
+	 * system_rev & 0x000000c0 -> IDCODE revision[6:7]
 	 * system_rev & 0x0000003f -> sys_boot[0:5]
 	 */
 	/* Embedding the ES revision info in type field */
 	system_rev = omap_ids[j].type;
+	/* Also add IDCODE revision info only two lower bits */
+	system_rev |= ((rev & 0x3) << 6);
 
 	/* Add in the device type and sys_boot fields (see above) */
 	if (cpu_is_omap24xx()) {