signals: microoptimize the usage of ->curr_target
Subsystems (3)
PATCH 1/1 signals: microoptimize the usage of ->curr_target
Suggested by Roland McGrath.
Initialize signal->curr_target in copy_signal(). This way ->curr_target is never == NULL, we can kill the check in __group_complete_signal's hot path.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/fork.c renamed from kernel/fork.c~4_CURR_TASK +1 -1
@@ -902,7 +902,7 @@ static int copy_signal(unsigned long clo sig->group_exit_code =0 ; sig->group_exit_task =NULL ; sig->group_stop_count =0 ; - sig->curr_target =NULL ; + sig->curr_target = tsk;init_sigpending (&sig->shared_pending);INIT_LIST_HEAD (&sig->posix_timers);
kernel/signal.c renamed from kernel/signal.c~4_CURR_TASK +0 -4
@@ -863,10 +863,6 @@ __group_complete_signal(int sig, struct* Otherwise try to find a suitable thread. */ t = signal->curr_target; -if (t ==NULL ) -/* restart balancing at this thread */ - t = signal->curr_target = p; -while (!wants_signal (sig, t)) { t =next_thread (t);if (t == signal->curr_target)
Quoted 1 line
Suggested by Roland McGrath.
Yes it was, and a good change too! :-)
Thanks,
Roland