inotify fixes in stable
Hi Greg,
I was hoping that the fixes for bug 7785 "BUG: at fs/inotify.c:172 set_dentry_child_flags()" could be added to the stable releases. I'm seeing these quite frequently at customer installations.
The relevant commits are d599e36a9ea85432587f4550acc113cd7549d12a and 0d71bd5993b630a989d15adc2562a9ffe41cd26d. Hopefully these do not depend on other updates. Nick would be the expert on that.
Rgds
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
Quoted 5 lines · Pierre Ossman
Hi Greg,
I was hoping that the fixes for bug 7785 "BUG: at
fs/inotify.c:172set_dentry_child_flags()" could be added to the stable releases. I'm seeing these quite frequently at customer installations.
In the future, stable stuff should be sent to the [email protected] email address and not directly to me, thanks.
Quoted 3 lines
The relevant commits are
d599e36a9ea85432587f4550acc113cd7549d12aand0d71bd5993b630a989d15adc2562a9ffe41cd26d. Hopefully these do not depend on other updates. Nick would be the expert on that.
Can you verify that if you apply just those 2 patches to the latest 2.6.24.3 kernel release, it fixes the issues for you?
thanks,
greg k-h
Quoted 10 lines · On Mon, 10 Mar 2008 09:03:17 -0700 Greg KH <[email protected]> wrote:
Quoted 5 lines · Pierre Ossman
Hi Greg,
I was hoping that the fixes for bug 7785 "BUG: at
fs/inotify.c:172set_dentry_child_flags()" could be added to the stable releases. I'm seeing these quite frequently at customer installations.In the future, stable stuff should be sent to the [email protected] email address and not directly to me, thanks.
Sorry. :/
Quoted 7 lines
Quoted 3 lines
The relevant commits are
d599e36a9ea85432587f4550acc113cd7549d12aand0d71bd5993b630a989d15adc2562a9ffe41cd26d. Hopefully these do not depend on other updates. Nick would be the expert on that.Can you verify that if you apply just those 2 patches to the latest 2.6.24.3 kernel release, it fixes the issues for you?
The system is an OpenSuse 10.3 system, so 2.6.22.y would be the interesting one. I'll see if I can get a custom kernel in there (I've been unable to reproduce the problem outside a production environment).
Rgds
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
Quoted 20 lines · Pierre Ossman
Quoted 10 lines · On Mon, 10 Mar 2008 09:03:17 -0700 Greg KH <[email protected]> wrote:
Quoted 5 lines · Pierre Ossman
Hi Greg,
I was hoping that the fixes for bug 7785 "BUG: at
fs/inotify.c:172set_dentry_child_flags()" could be added to the stable releases. I'm seeing these quite frequently at customer installations.In the future, stable stuff should be sent to the [email protected] email address and not directly to me, thanks.
Sorry. :/
Quoted 4 lines
Quoted 3 lines
The relevant commits are
d599e36a9ea85432587f4550acc113cd7549d12aand0d71bd5993b630a989d15adc2562a9ffe41cd26d. Hopefully these do not depend on other updates. Nick would be the expert on that.
Quoted 8 lines
Quoted 3 lines
Can you verify that if you apply just those 2 patches to the latest 2.6.24.3 kernel release, it fixes the issues for you?
The system is an OpenSuse 10.3 system, so 2.6.22.y would be the interesting one. I'll see if I can get a custom kernel in there (I've been unable to reproduce the problem outside a production environment).
2.6.22.y is no longer being released by me, so it isn't interesting to me at all :)
What about 2.6.24? Is this still an issue there?
thanks,
greg k-h
Quoted 10 lines · On Mon, 10 Mar 2008 13:31:16 -0700 Greg KH <[email protected]> wrote:
Quoted 5 lines · Pierre Ossman
The system is an OpenSuse 10.3 system, so 2.6.22.y would be the interesting one. I'll see if I can get a custom kernel in there (I've been unable to reproduce the problem outside a production environment).
2.6.22.y is no longer being released by me, so it isn't interesting to me at all :)
Oh? You made a release just 13 days ago, so I figured you were still giving it some love.
Quoted 1 line
What about 2.6.24? Is this still an issue there?
Judging from the kernel bugzilla, it would seem so.
But in my specific case, the guy on site was going to try an updated kernel from Suse's build system. I'll probably now the results tomorrow or the day after that.
Rgds
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
Quoted 10 lines · Pierre Ossman
Quoted 7 lines · On Mon, 10 Mar 2008 13:31:16 -0700 Greg KH <[email protected]> wrote:
Quoted 5 lines · Pierre Ossman
The system is an OpenSuse 10.3 system, so 2.6.22.y would be the interesting one. I'll see if I can get a custom kernel in there (I've been unable to reproduce the problem outside a production environment).
Quoted 6 lines
Quoted 3 lines
2.6.22.y is no longer being released by me, so it isn't interesting to me at all :)
Oh? You made a release just 13 days ago, so I figured you were still giving it some love.
In that release, I said it was going to be my last.
Quoted 7 lines
Quoted 1 line
What about 2.6.24? Is this still an issue there?
Judging from the kernel bugzilla, it would seem so.
But in my specific case, the guy on site was going to try an updated kernel from Suse's build system. I'll probably now the results tomorrow or the day after that.
Please let us know.
thanks,
greg k-h
Quoted 20 lines · Greg KH
Quoted 9 lines · Pierre Ossman
On Mon, 10 Mar 2008 13:31:16 -0700
Quoted 6 lines · Greg KH
Quoted 4 lines · Pierre Ossman
The system is an OpenSuse 10.3 system, so 2.6.22.y would be the interesting one. I'll see if I can get a custom kernel in there (I've been unable to reproduce the problem outside a production environment).
Quoted 5 lines
Quoted 2 lines
2.6.22.y is no longer being released by me, so it isn't interesting to me at all :)
Oh? You made a release just 13 days ago, so I figured you were still giving it some love.
In that release, I said it was going to be my last.
Quoted 2 lines
Quoted 1 line
What about 2.6.24? Is this still an issue there?
Quoted 7 lines
Quoted 5 lines
Judging from the kernel bugzilla, it would seem so.
But in my specific case, the guy on site was going to try an updated kernel from Suse's build system. I'll probably now the results tomorrow or the day after that.
Please let us know.
The messages should actually be harmless. There is a race in the debug code that can trigger them. But I wouldn't object to the patches going to -stable...
Quoted 5 lines · On Tuesday 11 March 2008 05:12:37 Nick Piggin wrote:
The messages should actually be harmless. There is a race in the debug code that can trigger them. But I wouldn't object to the patches going to -stable...
let me guess... the patch didn't get into 2.6.24.4, right? because I still get these noisy "WARNING: at fs/inotify.c:172 set_dentry_child_flags()" and probably alot of other kde4 users too?!
Regards,
Christian
Quoted 9 lines · * Chr ([email protected]) wrote:
Quoted 5 lines · On Tuesday 11 March 2008 05:12:37 Nick Piggin wrote:
The messages should actually be harmless. There is a race in the debug code that can trigger them. But I wouldn't object to the patches going to -stable...
let me guess... the patch didn't get into 2.6.24.4, right? because I still get these noisy "WARNING: at
fs/inotify.c:172set_dentry_child_flags()" and probably alot of other kde4 users too?!
a) doesn't appear to have been Cc'd to [email protected] until now (fell through one crack)
b) there was outstanding request from greg for clarification of the issue for 2.6.24 (fell through another crack)
Please just explicitly send the fixes to [email protected] and Cc Nick.
I'm actually disinclined to take 0d71bd5993b630a989d15adc2562a9ffe41cd26d which seems to primarily just remove the WARN_ON(), although that is assuming it is indeed no longer triggered with just the race fix, d599e36a9ea85432587f4550acc113cd7549d12a.
thanks,
-chris
Quoted 5 lines · On Tuesday 25 March 2008 01:42:33 Chris Wright wrote:
* Chr ([email protected]) wrote:
[...]
Please just explicitly send the fixes to [email protected] and Cc Nick.
Done...! I took both patches from the current git-tree.
but forgot to add a tested-by flag... well, but I added the patches, right?!
Quoted 5 lines
I'm actually disinclined to take
0d71bd5993b630a989d15adc2562a9ffe41cd26dwhich seems to primarily just remove theWARN_ON(), although that is assuming it is indeed no longer triggered with just the race fix,d599e36a9ea85432587f4550acc113cd7549d12a.
hmm, Nick said that the debug code is racy and "not very good at finding problems" either... But as long as the real fix has a _real_ change to get merged in 2.6.24.5, I'm happy ;-)
Quoted 3 lines
thanks,
-chris
Regards,
Christian