ide: remove obsoleted "idex=reset" kernel parameter

PATCH New Bartlomiej Zolnierkiewicz 1 participant 1 message Mar 10, 2008

Subsystems (2)

Documentation libata

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2008-03-10 23:34 UTC #0 lore raw

PATCH 5/5 ide: remove obsoleted "idex=reset" kernel parameter

Remove obsoleted "idex=reset" kernel parameter
(it has been obsoleted since 1 Nov 2004).

Then remove corresponding code from ide_probe_port() and no longer used ->reset field from ide_hwif_t.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 Documentation/ide/ide.txt |    2 --
 drivers/ide/ide-probe.c   |    9 ++-------
 drivers/ide/ide.c         |    6 ++----
 include/linux/ide.h       |    1 -
 4 files changed, 4 insertions(+), 14 deletions(-)

Documentation/ide/ide.txt +0 -2

Index: b/Documentation/ide/ide.txt
===================================================================
@@ -235,8 +235,6 @@ Summary of ide driver parameters for ker
 			  As for VLB, it is safest to not specify it.
 			  Bigger values are safer than smaller ones.
 
- "idex=reset"		: reset interface after probe
-
  "ide=reverse"		: formerly called to pci sub-system, but now local.
 
 The following are valid ONLY on ide0, which usually corresponds

drivers/ide/ide-probe.c +2 -7

Index: b/drivers/ide/ide-probe.c
===================================================================
@@ -799,14 +799,9 @@ static int ide_probe_port(ide_hwif_t *hw
 		if (drive->present)
 			rc = 0;
 	}
-	if (hwif->io_ports[IDE_CONTROL_OFFSET] && hwif->reset) {
-		printk(KERN_WARNING "%s: reset\n", hwif->name);
-		hwif->OUTB(12, hwif->io_ports[IDE_CONTROL_OFFSET]);
-		udelay(10);
-		hwif->OUTB(8, hwif->io_ports[IDE_CONTROL_OFFSET]);
-		(void)ide_busy_sleep(hwif);
-	}
+
 	local_irq_restore(flags);
+
 	/*
 	 * Use cached IRQ number. It might be (and is...) changed by probe
 	 * code above

drivers/ide/ide.c +2 -4

Index: b/drivers/ide/ide.c
===================================================================
@@ -1006,7 +1006,7 @@ static int __init ide_setup(char *s)
 		 */
 		static const char *ide_words[] = {
 			"minus1", "minus2", "minus3", "minus4",
-			"reset", "minus6", "ata66", "minus8", "minus9",
+			"minus5", "minus6", "ata66", "minus8", "minus9",
 			"minus10", "four", "qd65xx", "ht6560b", "cmd640_vlb",
 			"dtc2278", "umc8672", "ali14xx", NULL };

@@ -1088,9 +1088,7 @@ static int __init ide_setup(char *s)
 #else
 				goto bad_hwif;
 #endif
-			case -5: /* "reset" */
-				hwif->reset = 1;
-				goto obsolete_option;
+			case -5:
 			case -2:
 			case -1:
 			case 0:

include/linux/ide.h +0 -1

Index: b/include/linux/ide.h
===================================================================
@@ -521,7 +521,6 @@ typedef struct hwif_s {
 	unsigned	present    : 1;	/* this interface exists */
 	unsigned	serialized : 1;	/* serialized all channel operation */
 	unsigned	sharing_irq: 1;	/* 1 = sharing irq with another hwif */
-	unsigned	reset      : 1;	/* reset after probe */
 	unsigned	sg_mapped  : 1;	/* sg_table and sg_nents are ready */
 	unsigned	mmio       : 1; /* host uses MMIO */