Skip to contentSkip to conversation

isp1301 build breakage

DISCUSSION David Brownell 3 participants 3 messages Mar 12, 2008

lore
Share & tools
lore
#0 lore raw

CC drivers/i2c/chips/isp1301_omap.o
drivers/i2c/chips/isp1301_omap.c: In function 'isp1301_set_peripheral':
drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of function 'machine_is_omap_h2' drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of function 'machine_is_omap_h3' make[3]: *** [drivers/i2c/chips/isp1301_omap.o] Error 1
make[2]: *** [drivers/i2c/chips] Error 2
make[1]: *** [drivers/i2c] Error 2

This is on an H4 config, if that matters at all.

#1 lore raw
Quoted 9 lines · David Brownell

CC drivers/i2c/chips/isp1301_omap.o
drivers/i2c/chips/isp1301_omap.c: In function 'isp1301_set_peripheral':
drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of function 'machine_is_omap_h2' drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of function 'machine_is_omap_h3' make[3]: *** [drivers/i2c/chips/isp1301_omap.o] Error 1
make[2]: *** [drivers/i2c/chips] Error 2
make[1]: *** [drivers/i2c] Error 2

This is on an H4 config, if that matters at all.

I've pushed a quick fix to include mach-types.h.. In the long run that should use platform_data for passing any special options..

Tony

#2 lore raw
Quoted 7 lines · Tony Lindgren
Quoted 3 lines · David Brownell

CC drivers/i2c/chips/isp1301_omap.o
drivers/i2c/chips/isp1301_omap.c: In function 'isp1301_set_peripheral':
drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of

function 'machine_is_omap_h2'

Quoted 1 line

drivers/i2c/chips/isp1301_omap.c:1360: error: implicit declaration of

function 'machine_is_omap_h3'

Quoted 8 lines
Quoted 5 lines

make[3]: *** [drivers/i2c/chips/isp1301_omap.o] Error 1 make[2]: *** [drivers/i2c/chips] Error 2 make[1]: *** [drivers/i2c] Error 2

This is on an H4 config, if that matters at all.

I've pushed a quick fix to include mach-types.h.. In the long run that should use platform_data for passing any special options..

I've being working on that, sorry the delay but I'm quite busy with omap3 and twl. :-s

Signature · 5 lines
Best Regards,

Felipe Balbi
http://felipebalbi.com
[email protected]