Skip to contentSkip to conversation

clean up aperture_64.c

PATCH Pavel Machek 2 participants 2 messages Mar 13, 2008 – Mar 21, 2008 x86

lore
Share & tools
lore
#0 lore raw

Initializing to zero is generally bad idea, I hope it is right for __init data, too.

arch/x86/kernel/aperture_64.c +3 -3
index 608152a..88747f3 100644
@@ -26,11 +27,11 @@ #include <asm/dma.h>
 #include <asm/k8.h>
 
 int gart_iommu_aperture;
-int gart_iommu_aperture_disabled __initdata = 0;
-int gart_iommu_aperture_allowed __initdata = 0;
+int gart_iommu_aperture_disabled __initdata;
+int gart_iommu_aperture_allowed __initdata;
 
 int fallback_aper_order __initdata = 1; /* 64MB */
-int fallback_aper_force __initdata = 0;
+int fallback_aper_force __initdata;
 
 int fix_aperture __initdata = 1;
 
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 2 lines · Pavel Machek

Initializing to zero is generally bad idea, I hope it is right for __init data, too.

thanks Pavel, applied.

Ingo