Skip to contentSkip to conversation

eCryptfs: Swap dput() and mntput()

PATCH New Michael Halcrow 1 participant 1 message Mar 17, 2008 Ecrypt file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eCryptfs: Swap dput() and mntput()

ecryptfs_d_release() is doing a mntput before doing the dput. This patch moves the dput before the mntput.

Thanks to Rajouri Jammu for reporting this.

---

fs/ecryptfs/dentry.c +1 -1
index 841a032..5e59658 100644
@@ -80,8 +80,8 @@ static void ecryptfs_d_release(struct dentry *dentry)
 {
 	if (ecryptfs_dentry_to_private(dentry)) {
 		if (ecryptfs_dentry_to_lower(dentry)) {
-			mntput(ecryptfs_dentry_to_lower_mnt(dentry));
 			dput(ecryptfs_dentry_to_lower(dentry));
+			mntput(ecryptfs_dentry_to_lower_mnt(dentry));
 		}
 		kmem_cache_free(ecryptfs_dentry_info_cache,
 				ecryptfs_dentry_to_private(dentry));