drm: fix printk format warning
PATCH 1/1 drm: fix printk format warning
From: Randy Dunlap <[email protected]>
Fix gcc printk format warning:drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'
but doesn't the %08 leave room for truncation?
Signed-off-by Randy Dunlap <[email protected]>
--- drivers/char/drm/ati_pcigart.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/char/drm/ati_pcigart.c +3 -2
@@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi }else { address = gart_info->addr; bus_address = gart_info->bus_addr; -DRM_DEBUG ("PCI: Gart Table: VRAM %08X mapped at %08lX\n" , - bus_address, (unsigned long )address); +DRM_DEBUG ("PCI: Gart Table: VRAM %08llX mapped at %08lX\n" , + (unsigned long long )bus_address, + (unsigned long )address); } pci_gart = (u32 *) address;
ping.
Quoted 17 lines · On Tue, 18 Mar 2008 14:14:11 -0700 Randy Dunlap wrote:
From: Randy Dunlap <[email protected]>
Fix gcc printk format warning:
drivers/char/drm/ati_pcigart.c:125: warning: format '%08X' expects type 'unsigned int', but argument 3 has type 'dma_addr_t'but doesn't the %08 leave room for truncation?
Signed-off-by Randy Dunlap <[email protected]>--- drivers/char/drm/ati_pcigart.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/char/drm/ati_pcigart.c +0
-0@@ -122,8 +122,9 @@ int drm_ati_pcigart_init(struct drm_devi }else { address = gart_info->addr;
drivers/char/drm/ati_pcigart.c int drm_ati_pcigart_init(struct drm_devi
Quoted 10 lines
drivers/char/drm/ati_pcigart.c +3
-3bus_address = gart_info->bus_addr; -DRM_DEBUG ("PCI: Gart Table: VRAM %08X mapped at %08lX\n" , - bus_address, (unsigned long )address); +DRM_DEBUG ("PCI: Gart Table: VRAM %08llX mapped at %08lX\n" , + (unsigned long long )bus_address, + (unsigned long )address); } pci_gart = (u32 *) address; --
---
~Randy