iommu: it could use some documentation
Subsystems (2)
Fix coding style in pci-dma_64.c and add stubs for documentation. I hope someone fills the rest, I understand maybe off and soft...
---
commit 3ab83390752b5e71c6f04230dcd25c7789bb5099
tree 295a3567278a216785cd4e32dc3bcae2c5aad572
parent d5ac3c822e1036165b92d62e464be1e61c12d757
author Pavel <[email protected]> Wed, 19 Mar 2008 15:57:03 +0100 committer Pavel <[email protected]> Wed, 19 Mar 2008 15:57:03 +0100
Documentation/kernel-parameters.txt | 13 +++++++++++++ arch/x86/kernel/pci-dma_64.c | 20 ++++++++++---------- 2 files changed, 23 insertions(+), 10 deletions(-)
Documentation/kernel-parameters.txt +13 -0
@@ -811,6 +811,19 @@ and is between 256 and 4096 characters. inttest= [IA64] + iommu= [x86] + off + force + noforce + biomerge + panic + nopanic + merge + nomerge + forcesac + soft + + intel_iommu= [DMAR] Intel IOMMU driver (DMAR) option off Disable intel iommu driver.
arch/x86/kernel/pci-dma_64.c +10 -10
@@ -237,32 +237,32 @@ static __init int iommu_setup(char *p)return -EINVAL ;while (*p) { -if (!strncmp (p,"off" ,3 )) +if (!strncmp (p,"off" ,3 )) no_iommu =1 ;/* gart_parse_options has more force support */ -if (!strncmp (p,"force" ,5 )) +if (!strncmp (p,"force" ,5 )) force_iommu =1 ; -if (!strncmp (p,"noforce" ,7 )) { +if (!strncmp (p,"noforce" ,7 )) { iommu_merge =0 ; force_iommu =0 ; } -if (!strncmp (p,"biomerge" ,8 )) { +if (!strncmp (p,"biomerge" ,8 )) { iommu_bio_merge =4096 ; iommu_merge =1 ; force_iommu =1 ; } -if (!strncmp (p,"panic" ,5 )) +if (!strncmp (p,"panic" ,5 )) panic_on_overflow =1 ; -if (!strncmp (p,"nopanic" ,7 )) +if (!strncmp (p,"nopanic" ,7 )) panic_on_overflow =0 ; -if (!strncmp (p,"merge" ,5 )) { +if (!strncmp (p,"merge" ,5 )) { iommu_merge =1 ; force_iommu =1 ; } -if (!strncmp (p,"nomerge" ,7 )) +if (!strncmp (p,"nomerge" ,7 )) iommu_merge =0 ; -if (!strncmp (p,"forcesac" ,8 )) +if (!strncmp (p,"forcesac" ,8 )) iommu_sac_force =1 ;if (!strncmp (p,"allowdac" ,8 )) forbid_dac =0 ;
@@ -270,7 +270,7 @@ static __init int iommu_setup(char *p) forbid_dac =-1 ;#ifdef CONFIG_SWIOTLB -if (!strncmp (p,"soft" ,4 )) +if (!strncmp (p,"soft" ,4 )) swiotlb =1 ;#endif
Signature · 3 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/
Quoted 2 lines · Pavel Machek
Fix coding style in
pci-dma_64.cand add stubs for documentation. I hope someone fills the rest, I understand maybe off and soft...
thanks Pavel, i've applied your bits. This file could need a ton more cleanups.
Ingo
Quoted 4 lines · Pavel Machek
Fix coding style in
pci-dma_64.cand add stubs for documentation. I hope someone fills the rest, I understand maybe off and soft...Documentation/kernel-parameters.txt +1
-0+ iommu= [x86]
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. · line 824
Quoted 10 lines
Documentation/kernel-parameters.txt +10
-0+ off + force + noforce + biomerge + panic + nopanic + merge + nomerge + forcesac + soft
these are mostly quirks to get boards booting - few people use these for performance tuning. SAC has an address space limit (40 bits) but is faster, DAC can cover the physical address range but is slower. The softiotlb we better forget about ;-)
if you are interested in fixing this, the descriptions from Documentation/x86_64/boot-options.txt should/could be merged into Documentation/kernel-parameters.txt.
Ingo
Quoted 14 lines · Ingo Molnar
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. · line 824
Quoted 12 lines
Documentation/kernel-parameters.txt +11
-0+ iommu= [x86] + off + force + noforce + biomerge + panic + nopanic + merge + nomerge + forcesac + softthese are mostly quirks to get boards booting
Actually no. Except perhaps for iommu=soft none of them is related to any hardware issues. They all tune various performance trade offs and were supplied for performance tuning originally.
-Andi
Quoted 2 lines · Pavel Machek
Fix coding style in
pci-dma_64.cand add stubs for documentation. I hope someone fills the rest, I understand maybe off and soft...
The boot options are all documented in Documentation/x86_64/boot-options.txt, like all other x86-64 specific boot options.
-Andi