Skip to contentSkip to conversation

ioemu: Initialize ioport_opaque to zero

PATCH In review Samuel Thibault 1 participant 2 messages Mar 19, 2008

lore
Share & tools
lore

Samuel Thibault

author
#0 lore raw

PATCH 1/1 ioemu: Initialize ioport_opaque to zero

ioemu: Initialize ioport_opaque to zero
since register_ioport_read requires it.

Signed-off-by Samuel Thibault <[email protected]>
tools/ioemu/vl.c +1 -1
diff -r b3c8dcb98543 tools/ioemu/vl.c
@@ -281,7 +281,7 @@ void default_ioport_writel(void *opaque,
 
 void init_ioports(void)
 {
-    ioport_opaque = malloc(MAX_IOPORTS * sizeof(*ioport_opaque));
+    ioport_opaque = calloc(MAX_IOPORTS, sizeof(*ioport_opaque));
     ioport_read_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_read_table));
     ioport_write_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_write_table));
 }
author
#1 lore raw
Quoted 2 lines · Samuel Thibault, le Wed 19 Mar 2008 17:02:59 +0000, a écrit :

ioemu: Initialize ioport_opaque to zero
since register_ioport_read requires it.

Mmm, actually ioport_read/write_table need it too:

ioemu: Initialize ioport_opaque, ioport_read/write_table to zero

Signed-off-by Samuel Thibault <[email protected]>
tools/ioemu/vl.c +3 -3
diff -r b3c8dcb98543 tools/ioemu/vl.c
@@ -281,9 +281,9 @@ void default_ioport_writel(void *opaque,
 
 void init_ioports(void)
 {
-    ioport_opaque = malloc(MAX_IOPORTS * sizeof(*ioport_opaque));
-    ioport_read_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_read_table));
-    ioport_write_table = malloc(3 * MAX_IOPORTS * sizeof(**ioport_write_table));
+    ioport_opaque = calloc(MAX_IOPORTS, sizeof(*ioport_opaque));
+    ioport_read_table = calloc(3 * MAX_IOPORTS, sizeof(**ioport_read_table));
+    ioport_write_table = calloc(3 * MAX_IOPORTS, sizeof(**ioport_write_table));
 }
 
 /* size is the word size in byte */