ASoC/TLV320AIC3X: Stop I2C driver ID abuse
PATCH 1/1 ASoC/TLV320AIC3X: Stop I2C driver ID abuse
Please stop using random I2C driver IDs.
Also removed a pointless initialization to 0 of a static struct member.
Signed-off-by Jean Delvare <[email protected]>
Cc Jarkko Nikula <[email protected]>
---
I will push this to Linus through my i2c tree by the end of the week.
sound/soc/codecs/tlv320aic3x.c | 2 -- 1 file changed, 2 deletions(-)
sound/soc/codecs/tlv320aic3x.c +0 -2
@@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive .name = "aic3x I2C Codec", .owner = THIS_MODULE, }, - .id = I2C_DRIVERID_I2CDEV, .attach_adapter = aic3x_i2c_attach, .detach_client = aic3x_i2c_detach, - .command = NULL, }; static struct i2c_client client_template = {
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Takashi Iwai
Acked-byAt Thu, 20 Mar 2008 17:35:50 +0100,
Quoted 7 lines · Jean Delvare
Please stop using random I2C driver IDs.
Also removed a pointless initialization to 0 of a static struct member.
Signed-off-by Jean Delvare <[email protected]>Cc Jarkko Nikula <[email protected]>
Acked-by Takashi Iwai <[email protected]>
Quoted 2 lines
---
I will push this to Linus through my i2c tree by the end of the week.
OK, thanks.
Takashi
Quoted 22 lines
sound/soc/codecs/tlv320aic3x.c | 2 -- 1 file changed, 2 deletions(-)sound/soc/codecs/tlv320aic3x.c +0
-2@@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive .name = "aic3x I2C Codec", .owner = THIS_MODULE, }, - .id = I2C_DRIVERID_I2CDEV, .attach_adapter = aic3x_i2c_attach, .detach_client = aic3x_i2c_detach, - .command = NULL, }; static struct i2c_client client_template = {Signature · 2 lines
-- Jean Delvare
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c