tty: drop the BKL for driver/ldisc ioctl methods
PATCH 1/1 tty: drop the BKL for driver/ldisc ioctl methods
Now we have pushed the lock down we can stop wrapping the call with a lock in the tty layer
Signed-off-by Alan Cox <[email protected]>
drivers/char/tty_io.c +1 -8
@@ -3459,11 +3582,8 @@switch (cmd) {case TIOCSBRK :case TIOCCBRK : -if (tty->driver->ioctl) { -lock_kernel (); +if (tty->driver->ioctl) retval = tty->driver->ioctl (tty, file, cmd, arg); -unlock_kernel (); - }return retval;/* These two ioctl's always return success; even if */
@@ -3584,18 +3704,14 @@break ; }if (tty->driver->ioctl) { -lock_kernel (); retval = (tty->driver->ioctl)(tty, file, cmd, arg); -unlock_kernel ();if (retval != -ENOIOCTLCMD )return retval; } ld =tty_ldisc_ref_wait (tty); retval = -EINVAL ;if (ld->ioctl) { -lock_kernel (); retval = ld->ioctl (tty, file, cmd, arg); -unlock_kernel ();if (retval == -ENOIOCTLCMD ) retval = -EINVAL ; }